On Sun, Nov 11, 2007 at 03:52:22PM +0100, Carl-Daniel Hailfinger wrote:
Index: LinuxBIOSv2/src/superio/ite/it8716f/superio.c
--- LinuxBIOSv2/src/superio/ite/it8716f/superio.c (Revision 2953) +++ LinuxBIOSv2/src/superio/ite/it8716f/superio.c (Arbeitskopie) @@ -152,7 +152,7 @@ {&ops, IT8716F_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, {0x7ff, 0}, {0x7ff, 0x4},}, {&ops, IT8716F_KBCM, PNP_IRQ0,},
- // No 7 { 0,},
- {&ops, IT8716F_GPIO,}, {&ops, IT8716F_MIDI, PNP_IO0 | PNP_IRQ0, {0x7fe, 0x4},}, {&ops, IT8716F_GAME, PNP_IO0, {0x7ff, 0},}, {&ops, IT8716F_IR,},
Index: LinuxBIOSv2/src/superio/ite/it8716f/it8716f.h
--- LinuxBIOSv2/src/superio/ite/it8716f/it8716f.h (Revision 2953) +++ LinuxBIOSv2/src/superio/ite/it8716f/it8716f.h (Arbeitskopie) @@ -28,6 +28,7 @@ #define IT8716F_EC 0x04 /* Environment controller */ #define IT8716F_KBCK 0x05 /* Keyboard */ #define IT8716F_KBCM 0x06 /* Mouse */ +#define IT8716F_GPIO 0x07 /* GPIO */ #define IT8716F_MIDI 0x08 /* MIDI port */ #define IT8716F_GAME 0x09 /* GAME port */ #define IT8716F_IR 0x0a /* Consumer IR */
Indeed, this is a bug in the code. If it works and if you add a Signed-off-by line:
Acked-by: Uwe Hermann uwe@hermann-uwe.de
Uwe.