On Thu, Mar 25, 2010 at 8:52 AM, Stefan Reinauer stepan@coresystems.dewrote:
On 3/25/10 3:47 PM, Myles Watson wrote:
On 3/24/10 11:02 PM, repository service wrote:
-extern unsigned char AmlCode[]; +extern const acpi_header_t AmlCode;
And we're positive, this always does the right thing with gcc?
I am told that AmlCode is defined as array of (unsigned) char in some other file. Declaring it as some other type here is not valid C, and *will* break with GCC, with some options (-combine or LTO at least) -- it will not compile.
The biggest worry for me is incorrect execution. If it doesn't compile
when
it breaks, then that's a good thing.
Well, if it breaks with LTO, we should fix it right away... I'll try and prepare something.
What do the IASL folks suggest? Do they have a way of doing this "correctly"?
It seems like others must have this problem of needing to force a binary blob into a struct.
Thanks, Myles