Re: [coreboot] [PATCH] buildrom: openvsa Makefile fix

[Abhishek Kulkarni]

On Wed, Dec 10, 2008 at 10:00 AM, Ward Vandewege  wrote:
> On Wed, Dec 10, 2008 at 09:50:12AM -0700, Abhishek Kulkarni wrote:
> > openvsa.inc has no OPENVSA_LOG_DIR target, and considering that
> >    $(SOURCE_DIR)/$(OPENVSA_TARBALL) creates the LOG_DIR we don't need to
>
> add
> > dependency on the LOG_DIR.
>
> Actually, let's do it the other way around and remove that
>
> @ mkdir -p $(OPENVSA_LOG_DIR)
>
> while keeping the dependency on $(OPENVSA_LOG_DIR).
>
> That's cleaner. OK?

Sure, makes sense.

Also, most of the main targets already have a dependency on the LOG_DIR
targets. Is there a specific reason to add it to the TARBALL_TARGET too?

Corrected patch below:

Thanks
Abhishek

Index: geodevsa/openvsa.inc
===================================================================
--- geodevsa/openvsa.inc    (revision 255)
+++ geodevsa/openvsa.inc    (working copy)
@@ -19,7 +19,6 @@

$(SOURCE_DIR)/$(OPENVSA_TARBALL): | $(OPENVSA_LOG_DIR)
     @ mkdir -p $(SOURCE_DIR)/openvsa
-    @ mkdir -p $(OPENVSA_LOG_DIR)
     @ echo "Fetching openvsa..."
     @ $(BIN_DIR)/fetchsvn.sh $(OPENVSA_URL) $(SOURCE_DIR)/openvsa \
     $(OPENVSA_TAG) $@ > $(OPENVSA_FETCH_LOG) 2>&1
@@ -31,7 +30,6 @@
     @ touch $@

$(OPENVSA_SRC_DIR)/vsa_lx.bin: $(OPENVSA_STAMP_DIR)/.unpacked
-    @ mkdir -p $(OPENVSA_LOG_DIR)
     @ echo "Building openvsa..."
     @(unset LDFLAGS; $(MAKE) -C $(OPENVSA_SRC_DIR) \
     > $(OPENVSA_BUILD_LOG) 2>&1)
@@ -40,6 +38,9 @@
     @ mkdir -p $(shell dirname $(GEODE_UNCOMPRESSED_VSA))
     @ cp $< $@

+$(OPENVESA_STAMP_DIR) $(OPENVESA_LOG_DIR):
+    @ mkdir -p $@
+
 openvsa: $(OPENVSA_SRC_DIR)/vsa_lx.bin

openvsa-clean:
> Thanks,
> Ward.