Re: [coreboot] r3104 - trunk/coreboot-v2/src/devices

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ulf,
> Hmm, shouldn't the last line test the bit at *position* bitpos:
> return !!(tmp & (1 << bitpos));

Yep good catch. I will fix it and I'm sorry about that.

Btw the build is failing with:

srv/svn/linuxbios-extra/tmp/coreboot-v2-3104/src/devices/pnp_device.c:54: error:
`u8' undeclared (first use in this function)

Any idea why it works for me here?

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHuf8K3J9wPJqZRNURAuWjAKC06qQ4oDWULpiz9VqQSFtr3sDQIwCgwXLX
xRAaQi2o37MCn30payRIC1U=
=fKRK
-----END PGP SIGNATURE-----