Re: [coreboot] r3104 - trunk/coreboot-v2/src/devices

[Ulf Jordan]

On Mon, 18 Feb 2008, [e-mail] wrote:
> void pnp_set_enable(device_t dev, int enable)
> {
> pnp_write_config(dev, 0x30, enable?0x1:0x0);
> u8 tmp, bitpos;
> tmp = pnp_read_config(dev, 0x30);
> /* handle the virtual devices, which share same LDN register */
> bitpos = (dev->path.u.pnp.device >> 8) & 0x7;
> if (enable) {
> tmp |= (1 << bitpos);
> } else {
> tmp &= ~(1 << bitpos);
> }
> pnp_write_config(dev, 0x30, tmp);
>
> }
>
> int pnp_read_enable(device_t dev)
> {
> return !!pnp_read_config(dev, 0x30);
> u8 tmp, bitpos;
> tmp = pnp_read_config(dev, 0x30);
> /* handle the virtual devices, which share same LDN register */
> bitpos = (dev->path.u.pnp.device >> 8) & 0x7;
> return !!(tmp & bitpos);

Hmm, shouldn't the last line test the bit at *position* bitpos:

+	return !!(tmp & (1 << bitpos));

/ulf

r3104 - trunk/coreboot-v2/src/devices

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ulf,
> Hmm, shouldn't the last line test the bit at *position* bitpos:
> return !!(tmp & (1 << bitpos));

Yep good catch. I will fix it and I'm sorry about that.

Btw the build is failing with:

srv/svn/linuxbios-extra/tmp/coreboot-v2-3104/src/devices/pnp_device.c:54: error:
`u8' undeclared (first use in this function)

Any idea why it works for me here?

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHuf8K3J9wPJqZRNURAuWjAKC06qQ4oDWULpiz9VqQSFtr3sDQIwCgwXLX
xRAaQi2o37MCn30payRIC1U=
=fKRK
-----END PGP SIGNATURE-----

r3104 - trunk/coreboot-v2/src/devices

[Ulf Jordan]

On Mon, 18 Feb 2008, Rudolf Marek wrote:
> Btw the build is failing with:
>
> srv/svn/linuxbios-extra/tmp/coreboot-v2-3104/src/devices/pnp_device.c:54: error:
> `u8' undeclared (first use in this function)
>
> Any idea why it works for me here?

No, but all the failed builds are for powerpc targets. Include file 
differences between the platforms?

/ulf

r3104 - trunk/coreboot-v2/src/devices

[Ulf Jordan]

On Mon, 18 Feb 2008, Ulf Jordan wrote:
> On Mon, 18 Feb 2008, Rudolf Marek wrote:
> > Btw the build is failing with:
> >
> > srv/svn/linuxbios-extra/tmp/coreboot-v2-3104/src/devices/pnp_device.c:54: error:
> > `u8' undeclared (first use in this function)
> >
> > Any idea why it works for me here?
>
> No, but all the failed builds are for powerpc targets. Include file
> differences between the platforms?

I think it is necessary to use uint8_t in the code here, see attached 
patch.

/ulf

r3104 - trunk/coreboot-v2/src/devices

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Thanks,

Yep I fixing that too. Chatting on IRC with the rest of the folks so I got
preempted somehow.

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHugXO3J9wPJqZRNURApp1AKDJYrErALXbNLDFUx6C1MkAMKEIMQCdG4se
nephT+9rgi76mVk7UFnsYRU=
=oc0i
-----END PGP SIGNATURE-----

r3104 - trunk/coreboot-v2/src/devices

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all

I'm attaching the patch which should fix both problems. Fix the undefined u8
type and the bitpos selection in currently unused pnp_read_enable function.

Signed-off-by: Rudolf Marek

Thanks,

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHugb83J9wPJqZRNURAlJWAJ9qS3Ash3iTSyruG3hiznZhl8C1wQCcDnKt
PNnRF1Nsh3nGlUmNN4KqOv4=
=JBUL
-----END PGP SIGNATURE-----

r3104 - trunk/coreboot-v2/src/devices

[Stefan Reinauer]

* Rudolf Marek  [080218 23:30]:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi all
>
> I'm attaching the patch which should fix both problems. Fix the undefined u8
> type and the bitpos selection in currently unused pnp_read_enable function.
>
> Signed-off-by: Rudolf Marek

Acked-by: Stefan Reinauer

r3104 - trunk/coreboot-v2/src/devices

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Thanks,
r3109

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHuzzE3J9wPJqZRNURAsJhAJ44hHQv9SF9IEIzxC+Nl5s4A8HmtgCff6Nz
64DJRHSDKo0Dz5jfdlRTEio=
=wGIy
-----END PGP SIGNATURE-----