Re: [coreboot] [commit] r6127 - in trunk/src: mainboard/asus/p2b northbridge/intel/i440bx/acpi southbridge/intel/i82371eb southbridge/intel/i82371eb/acpi

[Uwe Hermann]

On Sun, Nov 28, 2010 at 12:06:56PM +0100, Tobias Diedrich wrote:
> BTW, my first idea was to use an acpi method that looks up pmbase in
> the pci cfg space, but when I define a method like this:
>     Method(TEST, 2)
>     {
>             Return (Add(Arg0, Arg1))
>     }
>
> I get:
> |build/mainboard/asus/p2b/dsdt.ramstage.asl     9:   Processor (CPU0,
> |0x01, TEST(0xe400, 0x10), 0x06) {}
> |Error    4096 -       syntax error, unexpected PARSEOP_NAMESEG,
> |expecting ')' ^

Not sure if or how this can be fixes, but..
> While using the builtin Add() directly works:
>
> Signed-off-by: Tobias Diedrich

...this solution looks nice and readable too.

Acked-by: Uwe Hermann

Uwe.