Re: [coreboot] [PATCH] First support for HP DL145 G3

[Myles Watson]

On Wed, Apr 22, 2009 at 9:29 AM, Tom Sylla  wrote:
> On Wed, Apr 22, 2009 at 8:00 AM, samuel  wrote:
> > VGA output is still not working. I have tried both YABEL and
> >
> > X86BIOS to load the vga rom but i get errors...
> > X86BIOS: http://merlin.ugent.be/~samuel/dl145g3/vgarom/corebootx86bios.log
> > relevant part:
> > On mainboard, rom address for PCI: 00:04.0 = fff00000
> > copying VGA ROM Image from fff00000 to 0xc0000, 0x8000 bytes
> > entering emulator
> > int1a vector at 274af
> >
> > YABEL: http://merlin.ugent.be/~samuel/dl145g3/vgarom/corebootYABEL.log
> > relevant part:
> > On mainboard, rom address for PCI: 00:04.0 = fff00000
> > copying VGA ROM Image from fff00000 to 0xc0000, 0x8000 bytes
> > pci_cfg_read(): Config read access invalid device! bus: 00 (00),
> > devfn: 00 (20), offs: 00
>
> I only see two "int 1a"s in the ROM binary:
>
> seg000:77DC B8 02 B1                          mov     ax, 0B102h
> seg000:77DF B9 41 15                          mov     cx, 1541h
> seg000:77E2 BA B9 10                          mov     dx, 10B9h
> seg000:77E5 BE 00 00                          mov     si, 0
> seg000:77E8 CD 1A                             int     1Ah
> ...
> seg000:7801 B8 02 B1                          mov     ax, 0B102h
> seg000:7804 B9 43 52                          mov     cx, 5243h
> seg000:7807 BA B9 10                          mov     dx, 10B9h
> seg000:780A BE 00 00                          mov     si, 0
> seg000:780D CD 1A                             int     1Ah
>
> so it is searching for the 0th instance of ven/dev 10b9:1541 or 10b9:5243:
> http://www.ctyme.com/intr/rb-2372.htm
>
> Those are:
> 10b9  ALi Corporation
>        1541  M1541
>                10b9 1541  ALI M1541 Aladdin V/V+ AGP System Controller
>        5243  M1541 PCI to AGP Controller
>
> which seems kind of weird. Maybe it does some workaround when on a
> platform with those devices.
>
> Also, is there any tracing you can enable (or just add) in the
> emulators? (to see more closely where it is failing, there is probably
> more execution after the int 1a and the config read of 0) I don't know
> if YABEL's and X86BIOS's messages are warnings or errors.

It turns out that this was caused by an extra VGA entry in the Config.lb

# when HT_CHAIN_END_UNITID_BASE
(0,1) < HT_CHAIN_UNITID_BASE (6,,,,),
                                       device pci 4.0 on end # VGA  /*
REMOVE THIS ONE */

chip drivers/pci/onboard
                                               # it is in bcm5785_0
bus, but the device id can
                                               # not be changed even
unitid is changed, fake one
                                               # to get the rom_address
                                               # if
HT_CHAIN_END_UNITID_BASE=0, it is 4,
                                               # if
HT_CHAIN_END_UNITID_BASE=1, it is 3
                                               device pci 4.0 on end
                                               register "rom_address"
= "0xfff00000"
                                       end

It was trying to initialize the device, but it wasn't correctly
connected to the bus.  Here's the new failure.  Now it looks like it's
not finding the ROM anymore.

new log: http://merlin.ugent.be/~samuel/dl145g3/vgarom/coreboot-3.log

Thanks,
Myles