Re: [coreboot] [patch][v2]:fam10 microcode

[Ward Vandewege]

On Tue, Jun 02, 2009 at 02:27:58PM -0600, Marc Jones wrote:
> You are the first to try this on a real system. Nothing is jumping out
> at me in the code. If you can put in some debug checks around there it
> will be helpful to figure out.

Sure. I've sprinkled some debug code and traced the hang to this bit of code
in cpu/amd/model_10xxx/init_cpus.c, void AMD_SetHtPhyRegister:

/* Now get the current phy register data
     * LinkPhyDone = 0, LinkPhyWrite = 0 is a read
     */
    phyReg |= fam10_htphy_default[entry].htreg;
    pci_write_config32(NODE_PCI(node, 4), phyBase, phyReg);

do {
      val = pci_read_config32(NODE_PCI(node, 4), phyBase);
    } while (!(val & HTPHY_IS_COMPLETE_MASK));

That's an infinite loop on the second CPU, apparently.

I've uploaded the boot log with debug output, as well as my modified
init_cpus.c file with all the debug printing:

http://ward.vandewege.net/coreboot/h8dmr/fam10/h8dmr-n.cap

http://ward.vandewege.net/coreboot/h8dmr/fam10/init_cpus-n.c

Thanks,
Ward.