Re: [coreboot] [patch] fix intel 82810 onboard VGA and SDRAM functions

[Uwe Hermann]

Quick review below, I didn't yet find the time to test on hardware, will
hopefully be able to do that today.
> val = 0;
> val = pci_read_config8(PCI_DEV(0, 0, 0), MISSC2);

The 'val = 0' should no be needed if you do pci_read_config8()
right after that.
> val |= 0x06;
> val |= 0xc6;

Why this? Only the last line alone should also do?
> +#ifdef CONFIG_VIDEO_MB
> /* check for VGA reserved memory
> * possible CONFIG_VIDEO_MB values are 512(kb) and 1(mb)
> */
> if (CONFIG_VIDEO_MB == 512) {
> 	tomk -= 512;
> 	printk_debug("Allocating 512KB of RAM for VGA\n");
> } else if (CONFIG_VIDEO_MB == 1) {
> 	tomk -= 1024 ;
> 	printk_debug("Allocating 1MB of RAM for VGA\n");
> } else {
> 	/* assume no vga if incorrect value */
> 	tomk == tomk;

Isn't this is no-op? Or am I missing something?

Uwe.