Re: [coreboot] [commit] r6212 - in trunk/src: drivers/dec/21143 mainboard/hp/dl145_g1 mainboard/hp/dl145_g3 mainboard/hp/dl165_g6_fam10 mainboard/nokia/ip530 southbridge/ti/pci1x2x

[Stefan Reinauer]

On 12/26/10 3:12 PM, repository service wrote:
> Modified: trunk/src/drivers/dec/21143/21143.c
>
> --- trunk/src/drivers/dec/21143/21143.c	Sun Dec 26 06:24:50 2010	(r6211)
> +++ trunk/src/drivers/dec/21143/21143.c	Sun Dec 26 15:12:38 2010	(r6212)
> @@ -38,33 +38,40 @@
> /* Command and status configuration (offset 0x04) */
> pci_write_config32(dev, 0x04,
> 	   CONFIG_DEC21143_COMMAND_AND_STATUS_CONFIGURATION);
> printk(BIOS_DEBUG, "0x04 = %08x (07 01 80 02)\n",
>       pci_read_config32(dev, 0x04));
> /* Cache line size (offset 0x0C) */
> pci_write_config8(dev, 0x0C, CONFIG_DEC21143_CACHE_LINE_SIZE);
> printk(BIOS_DEBUG, "0x0c = %08x (00 80 00 00)\n",
>       pci_read_config32(dev, 0x0C));
> /* Expansion ROM base address (offset 0x30) */
> pci_write_config32(dev, 0x30,
> 	   CONFIG_DEC21143_EXPANSION_ROM_BASE_ADDRESS);

This does not seem to make much sense for the 21143 ... Why is it needed?
Generally such stuff does not belong in Kconfig, but in this particular
case the resource allocator should do the right thing already.
> printk(BIOS_DEBUG, "0x30 = %08x (0x00000000)\n",
>       pci_read_config32(dev, 0x30));
>
> }

Merry christmas,
Stefan