Re: [LinuxBIOS] [PATCH] AMD Barcelona(family 10) support 1 of 4 repost

[Myles Watson]

Index: LinuxBIOSv2/src/cpu/amd/car/cache_as_ram.inc
===================================================================
...
+	movl	%edx, %eax
+		wrmsr
    movl	$0x269, %ecx
    wrmsr

Extra tab before wrmsr

+#if CAR_FAM10 == 1
+#define CacheSizeAPStack 0x400 /* 1K */
+//#define CacheSizeAPStack 0x200 /* 512 */
+#endif

A comment of when you might want to switch to 512 would be nice, or just
remove the 512.

I don't have the hardware to test with Barcelona, but the patch doesn't
change the functionality of the base code (except for adding some POST
codes).

Thanks for separating the patches, it made it a lot easier to see the
changes.

Myles

Acked-by: Myles Watson
> -----Original Message-----
> From: [e-mail] [mailto:linuxbios-
> [e-mail]] On Behalf Of Marc Jones
> Sent: Thursday, December 13, 2007 6:32 PM
> To: LinuxBIOS Mailing List
> Subject: Re: [LinuxBIOS] [PATCH] AMD Barcelona(family 10) support 1 of 4
> repost
>
> Marc Jones wrote:
> > Here is the initial patches for AMD Barcelona support! These patches
> > provide support for the Barcelona revision Bx. There is still a lot of
> > work to do as you will see in the FIXME comments. Please focus most
> > attention on the few places where changes were made to preexisting
> > files. I understand that these patches are large and will take some time
> > to get through. My hope is that they are accepted soon so that we can
> > continue to develop and amend the code as we find issues and support
> > more features.
> >
> > A buildrom update will follow.
> >
> > Marc
>
> I separated out the whitespace and other cleanup to a cleanup patch. I
> also removed two files that were no longer used from the patch. This
> patch is now two patches but this should make it easier to review.
>
> For those with email issues, get the entire patch set here:
> http://linuxbios.org/~mjones/barc121307.tar.gz
>
> Marc