Quoting Corey Osgood corey.osgood@gmail.com:
On Mon, Mar 31, 2008 at 1:16 PM, joe@smittys.pointclark.net wrote:
Quoting Ed Swierk eswierk@arastra.com:
The early init code of several Intel southbridge chipsets calls pci_locate_device() to locate the SMBus controller and LPC bridge devices on the PCI bus. Since these devices are always located at a fixed PCI bus:device:function, the code can be simplified by hardcoding the devices.
Signed-off-by: Ed Swierk eswierk@arastra.com
Looks good, but I don't think we need to add any patches to the i82801ca, i82801db, i82801dbm, or i82801er. The southbridge code for these should not be used, and should be dropped. Everyone should be using the i82801xx code for all ICH's. I propose we drop that code now that the i82801xx is stable, so cool people like Ed do not waste their time on it :-)
Thanks - Joe
As the guy who put together the i82801xx, I'd have to NAK that. If we had more boards to test it on (especially the ones already in the tree, like the intel dev boards and tyan board), then I'd say go for it, but not until we know it works in place of the current chips. When I put together the i82801xx, I tried to "steal" the best code from all of them, and put together something that would be as generic and full-featured as possible. In the process, I got rid of some system-specific bits, especially from the i82801er, that may have been required for the systems that used them. I would say it's probably safe to drop the i82801dbm, since it's not used by any ports and you're using that chip with the rm4100.
Ack that. The RM4100 has a i82801DB ICH4 and I am using the i82801xx code. The original i82801DB code never worked right, so can we at least drop that one?
Thanks - Joe