Explicitly set the CLKIN to 24 MHz on all ITE Super I/Os, otherwise serial output might not always work (correctly). Thanks Philipp Degler pdegler@rumms.uni-mannheim.de for testing and reporting this issue.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
---
On Wed, Nov 29, 2006 at 01:51:27PM +0100, Philipp Degler wrote:
we've tested the it8712f code, too. We see serial output on our ASUS a8ne. It is equiped with a ck804 SB and 1GB of RAM and a Athlon64 CPU.
But we needed to set the clock to 24MHz in order to see valid serial output.
Index: src/superio/ite/it8712f/it8712f_early_serial.c
--- src/superio/ite/it8712f/it8712f_early_serial.c (Revision 2507) +++ src/superio/ite/it8712f/it8712f_early_serial.c (Arbeitskopie) @@ -78,7 +78,7 @@ it8712f_sio_write(IT8712F_IR, 0x30, 0x1); /* Consumer IR */
/* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
/* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); */
it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); /* Clear software suspend mode (clear bit 0). TODO: Needed? */ /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */
Thanks a lot!
For the next patch please add a sign-off line, otherwise we cannot commit your patch. See also http://www.linuxbios.org/Development_Guidelines
Cheers, Uwe.