Re: [coreboot] [PATCH] Enable Direct TMDS for the RS690

[Libra Li]

Hello,

I had reference "AMD RS690 ASIC Family Register Programming
Requirements". It's in "Chapter 6 PCIE Initialization for TMDS". That is
show "step 6".
        Thanks.

2009/8/26 Marc Jones
> On Fri, Aug 21, 2009 at 12:36 PM, Daniel Toussaint
> wrote:
> > Enable Direct TMDS for the RS690, which allows to display on HDMI and DVI
> > monitors.
> > Signed-off-by: Libra Li
>
> Hi,
> Thanks for the patch.
>
> Why add the code to step 6 in rs690_gfx.c when there seems to be a
> spot reserved for it in  step 2?
>    /* step 2, TMDS, (only need if CMOS option is enabled) */
>    if (cfg->gfx_tmds) {
>    }
>
>
> Marc