Re: [coreboot] Ouch: romcc "x[0] |= something" patch causes another crash

[Patrick Georgi]

Am 15.03.2010 03:32, schrieb Keith Hui:
> Hi all,
>
> I regret to report that the romcc patch circulated earlier to fix the
> segfault I reported, is now causing another segfault. This also seems to
> be triggered by something in the 440BX code, as it didn't segfault when
> I compile for any mainboards that isn't 440BX. As of now I don't know
> what this new segfault is. I'll report back with more findings.

It seems the problem was that copy_triple() isn't supposed to be used on
flattened (and simple) nodes.
I built a simple test case that failed:
void main(void) {
        int c = 0;
        c |= 4;
}

With the attached patch, this testcase, your testcase, and a full abuild
run work.

Signed-off-by: Patrick Georgi