Re: [coreboot] [PATCH] New Socket370 and Model 68x for CAR

[Joseph Smith]

> > > This should be FCPGA370 or mFCPGA370
> >
> > No, "m" means mobile chip. Socket 370 is not a mobile chip.
> > >
>
> Afaik the m in mfcpga means micro

Ah yes sorry. No the Socket 370 is still not a micro or mobile chip.
> > > > Index: src/cpu/intel/model_68x/model_68x_init.c
> > > >
> > > > --- src/cpu/intel/model_68x/model_68x_init.c (revision 0)
> > > > +++ src/cpu/intel/model_68x/model_68x_init.c (revision 0)
> > >
> > > [..]
> > > > +static struct cpu_device_id cpu_table[] = {
> > >
> > > Do add 680 here too. In fact, if you add 680 all the others can be
> > > omitted.
> >
> > ok, why? 680 will cover everything?
>
> Yes. It will mask the ID with fff0

ok
> > > > { X86_VENDOR_INTEL, 0x0681 },
> > > > { X86_VENDOR_INTEL, 0x0683 },
> > > > { X86_VENDOR_INTEL, 0x0686 },
> > > > { X86_VENDOR_INTEL, 0x068a },
> > > > { 0, 0 },
> > > >
> > > > +};
> > > >
> > > > +static const struct cpu_driver driver __cpu_driver = {
> > > > .ops =&cpu_dev_ops,
> > > > .id_table = cpu_table,
> > > >
> > > > +};