Peter Stuge wrote:
Stefan Reinauer wrote:
+#include <../../../northbridge/amd/amdk8/amdk8_acpi.h>
../../../ that can't be right. Maybe the .h should go into include/ somewhere instead?
I don't think I can agree... northbridge specific code should really really live under northbridge.
Code no question - but headers that are for use elsewhere?
Absolutely. If a component uses headers from another component, it should get them from there. A clean design demands we do not mix generic code and component code.
I realize this is v2, but maybe want to improve that anyway?
Which is why I wrote the suggestion to begin with. Breaking the component design is very far from what the more modular v3 design ever tried to achieve. If we broke v3 in this matter, we must fix it too. As Ron said. It can be done with a simple -I flag. No component code/headers under /include, it just doesn't make sense from a design perspective, and breaking the design for syntactic sugar is not a good approach.
Stefan