On Fri, Nov 23, 2007 at 12:14:43AM +0100, Stefan Reinauer wrote:
- Stefan Reinauer stepan@coresystems.de [071123 00:04]:
- Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net [071122 21:44]:
The introduction of the _SHARED macros had one flaw: If multiple files had _SHARED defined during compilation, each of them would contain an assignment of stage0_printk to *printk. During linking, this caused errors as multiple definitions of printk existed. Make sure _SHARED alone gives you only the printk prototype, and iff _MAINOBJECT is defined as well, include the assignment.
Signed-off-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
I like it, but I suggest to simplify the code further.
Uwe was faster. So here's the diff without Carl-Daniel's patch
it gets rid of the per-file rules for initram code completely.
Very nice!
Patch is Signed-off-by: Stefan Reinauer stepan@coresystems.de
Acked-by: Uwe Hermann uwe@hermann-uwe.de
I think we should go even further and specify the INITRAM_SOURCE instead of INITRAM_OBJ because those are the files we care about. (And it will make proper dependencies easier at some point)
Yeah, sounds good.
+# ram initialization code can not be linked at a specific address,
ram -> RAM
Uwe.