Re: [LinuxBIOS] [RFC] v3: dts fixes and questions

[ron minnich]

On 6/30/07, Uwe Hermann  wrote:
> On Sat, Jun 30, 2007 at 04:27:27PM -0700, ron minnich wrote:
> > On 6/30/07, Peter Stuge  wrote:
> > > On Sat, Jun 30, 2007 at 11:43:20PM +0200, Stefan Reinauer wrote:
> > > > So instead of adding enabled; to all device nodes, we should add
> > > > disabled to those that we do not want enabled. What do you think?
> > >
> > > We should definately optimize for the common case whatever it is.
> >
> > What I can do is look for a disable property in each node. If it is
> > NOT found, emit
> > .enabled = 1;
> > If it is found,
> > .enabled = 0;
> >
> > sound ok?
>
> Why not, instead of 'enabled;', use
>   enabled="0"
> or
>   enabled="1"
> then? That has the benefit that you don't have to know what the default
> is (enabled or disabled), you know everything you need just by looking
> at the dts itself.
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (GNU/Linux)
>
> iD8DBQFGhvBIXdVoV3jWIbQRAgQoAJ0dDBxSH2BlcI7u0ldL93XOtM57/gCbB7nD
> 120zDwDQEbqpwuyLjU8xfAE=
> =hPcG
> -----END PGP SIGNATURE-----