Re: [coreboot] [PATCH] x86: ioremap mptable -v2

[Ingo Molnar]

* Ingo Molnar  wrote:
> > } else if (mpf->physptr) {
> > struct mpc_table *mpc;
> > unsigned long size;
> >
> > mpc = early_ioremap(mpf->physptr, PAGE_SIZE);
> > size = mpc->length;
> > apic_printk(APIC_VERBOSE, "  mpc: %lx-%lx\n", (unsigned long)mpf->physptr,
> > 	 mpf->physptr + size);
> > early_iounmap(mpc, PAGE_SIZE);
> > mpc = early_ioremap(mpf->physptr, size);
>
> no objections, but this bit of __get_smp_config() needs to be 
> done cleaner - the whole mpf->physptr != 0 bit should probably 
> go into a helper function.

and if you do that it should be done via two patches, in two 
steps: first patch is a pure cleanup that moves this bit of 
__get_smp_config() into a helper function. The second patch then 
adds the early_ioremap().

Ingo