On 13.05.2008 08:52, Mart Raudsepp wrote:
Ühel kenal päeval, T, 2008-05-13 kell 03:11, kirjutas Carl-Daniel Hailfinger:
On 09.05.2008 19:29, ron minnich wrote:
On Fri, May 9, 2008 at 7:06 AM, Andrei Birjukov wrote:
- Another option would be to globally force the PCI_COMMAND_MASTER in
pci_probe_dev(), if the base class is PCI_BASE_CLASS_NETWORK.
then we'll hit the same problem with disk potentially or any other bus master device? Not sure.
I think we need to make it clear to the user: this is being done because their OS is defective, and it is dangerous. But we've got to support it, so that's life. It really ought to be a Kconfig option. (this is v3 I assume). And the help needs to make clear why this is being done. I don't mind it if you want to beat WinCE over the head.
Andrei was talking about v2. With v3, we can simply add a "busmaster" property to the dts object which is used to set the busmastering flag in stage6 or so.
No, we were (me on IRC beforehand, Andrei on mailing list) talking about v3.
OK. I thought v2 because Andrei talked about "src/drivers/pci/rtl8139" and no v3 path begins with src/.
I didn't see any such option for the dts in v3 codebase, or rather, the only two places PCI_COMMAND_MASTER is used is where it is explicitly enabled for PCI Bridge IO Resources and PCI_BASE_CLASS_SYSTEM devices - nowhere else. How is this property set then?
Create this property in the base dts and add code to stage6 to act on the setting.
Regards, Carl-Daniel