Re: [coreboot] [patch] fix intel 82810 onboard VGA and SDRAM functions

[Myles Watson]

On Tue, May 12, 2009 at 8:12 AM, Joseph Smith  wrote:
> > > +#ifdef CONFIG_VIDEO_MB
> > > /* check for VGA reserved memory
> > > * possible CONFIG_VIDEO_MB values are 512(kb) and 1(mb)
> > > */
> > > if (CONFIG_VIDEO_MB == 512) {
> > > tomk -= 512;
> > > printk_debug("Allocating 512KB of RAM for VGA\n");
> > > } else if (CONFIG_VIDEO_MB == 1) {
> > > tomk -= 1024 ;
> > > printk_debug("Allocating 1MB of RAM for VGA\n");
> > > } else {
> > > /* assume no vga if incorrect value */
> > > tomk == tomk;
> >
> > Isn't this is no-op? Or am I missing something?
>
> I don't know what you mean no-op?

tomk==tomk doesn't do anything.  It would probably be better to leave
out that else branch.
> Are you taking about the "#ifdef CONFIG_VIDEO_MB", because I don't think
> that is necessary.

It should be #if CONFIG_VIDEO_MB >0 if we use it.  We don't use #ifdef
in v2 because the options are always defined if they are used.

Thanks,
Myles