Re: [coreboot] SB800 patch for adding A13 ID for ASRock 880G Pro3 (was: unsupported mb questions (amd fam10h))

[Paul Menzel]

Dear Roman,

sorry for digging up this thread.

Am Sonntag, den 15.07.2012, 11:50 +0400 schrieb Roman Elshin:
> I try to get coreboot working with asrock 880g pro3 board.
>
> First problem: spd eprom say that memory ddr1600 capable, but it is not 
> so, is there are right way to limit memory frequency at ddr1333?
>
> Other problem, may be related as machine with broken memory are very
> unpredictable: boot process stop with "It is not SB800 or SB810"
> message. I try to enable sb850 by this patch, but looks like it is not
> enough, most of time coreboot does not detect hdd. Sometimes  in very
> rare case it is possible to boot from sata. Are sb850 supported by
> coreboot?
>
> diff -urN a/src/southbridge/amd/sb800/early_setup.c
> b/src/southbridge/amd/sb800/early_setup.c
> --- a/src/southbridge/amd/sb800/early_setup.c	2012-07-14
> 19:00:40.000000000 +0400
> +++ b/src/southbridge/amd/sb800/early_setup.c	2012-07-14
> 21:49:54.000000000 +0400
> @@ -94,7 +94,10 @@
>    	rev = REV_SB800_A11;
>    } else if (rev_id == 0x41) {
>    	rev = REV_SB800_A12;
> } else {
> } else if (rev_id == 0x42) {
> rev = REV_SB800_A13;
> }
> else {
> die("It is not SB800 or SB810\r\n");
>  }
>
> diff -urN a/src/southbridge/amd/sb800/sb800.h
> b/src/southbridge/amd/sb800/sb800.h
> --- a/src/southbridge/amd/sb800/sb800.h	2012-07-14 19:00:40.000000000
> +0400
> +++ b/src/southbridge/amd/sb800/sb800.h	2012-07-14 21:49:10.000000000
> +0400
> @@ -48,7 +48,7 @@
>
> #define REV_SB800_A11	0x11
>  #define REV_SB800_A12	0x12
>
> +#define REV_SB800_A13	0x13
>
> #ifdef __PRE_RAM__
>  void sb800_lpc_port80(void);

This patch is useful nevertheless. Could you register to Gerrit [1] and
push this patch to it? Otherwise could you please reply with your
Signed-off-by line so somebody else can upload it?

Thanks,

Paul

[1] http://www.coreboot.org/Git