Re: Cache On and ECC clear

[Li-Ta Lo]

On Fri, 2004-03-26 at 01:06, Eric W. Biederman wrote:
> Li-Ta Lo  writes:
> > Eric,
> >
> > I tried to call cache_on() first than the cpufixeup()
> > in cpu.c to fix the "slow ecc clear" problem. It still
> > works that way. Is there any reason we can't do this ?
>
> Hmm.  I don't see this.  I have the cache on and things
> clear quite quickly.  I may have a slightly different calling
> order then the standard tree.
>
> Ollie can you compare what is checked into the tree with 
> the last release I did for Lightning?  It works there...

In LNXI tree it's like:

/* Turn on caching if we haven't already */
        cache_on(mem);

display_cpuid();
        mtrr_check();
#if 1
        /* some cpus need a fixup done. This is the hook for doing that.
*/
        cpufixup(mem);
#endif

and in the CVS tree it's:

/* some cpus need a fixup done. This is the hook for doing that. */
    cpufixup(mem);

/* Turn on caching if we haven't already */
    cache_on(mem);

display_cpuid();
    mtrr_check();

Ollie