Re: [coreboot] [patch] fix intel 82810 onboard VGA and SDRAM functions

[Joseph Smith]

> > +#ifdef CONFIG_VIDEO_MB
> > /* check for VGA reserved memory
> > * possible CONFIG_VIDEO_MB values are 512(kb) and 1(mb)
> > */
> > if (CONFIG_VIDEO_MB == 512) {
> > 	tomk -= 512;
> > 	printk_debug("Allocating 512KB of RAM for VGA\n");
> > } else if (CONFIG_VIDEO_MB == 1) {
> > 	tomk -= 1024 ;
> > 	printk_debug("Allocating 1MB of RAM for VGA\n");
> > } else {
> > 	/* assume no vga if incorrect value */
> > 	tomk == tomk;
>
> Isn't this is no-op? Or am I missing something?

I don't know what you mean no-op? 
Are you taking about the "#ifdef CONFIG_VIDEO_MB", because I don't think
that is necessary.
This came from the i830, but I don't use "#ifdef CONFIG_VIDEO_MB" and it
works fine.
Intel onboard "shared" graphics memory is always just below TOM.