Author: oxygene Date: Fri Nov 19 11:16:43 2010 New Revision: 6097 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6097
Log: Add test to check for up-to-date GPL license headers to lint. "make lint" should not stop after first failed test. Improve "make lint" output.
Signed-off-by: Patrick Georgi patrick.georgi@coresystems.de Acked-by: Patrick Georgi patrick.georgi@coresystems.de
Added: trunk/util/lint/lint-000-license-headers (contents, props changed) Modified: trunk/Makefile trunk/util/lint/lint-001-no-global-config-in-romstage
Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Fri Nov 19 01:29:32 2010 (r6096) +++ trunk/Makefile Fri Nov 19 11:16:43 2010 (r6097) @@ -367,9 +367,9 @@ dongle.py -c /dev/term/1 $(obj)/coreboot.rom EOF
lint: - LINTLOG=`mktemp`; \ + FAILED=0; LINTLOG=`mktemp`; \ for script in util/lint/lint-*; do \ - echo `basename $$script`; \ + echo; echo `basename $$script`; \ grep "^# DESCR:" $$script | sed "s,.*DESCR: *,," ; \ echo ========; \ $$script > $$LINTLOG; \ @@ -379,9 +379,11 @@ echo test failed: ; \ cat $$LINTLOG; \ rm -f $$LINTLOG; \ - exit 1; \ - fi \ + FAILED=$$(( $$FAILED + 1 )); \ + fi; \ + echo ========; \ done; \ + test $$FAILED -eq 0 || { echo "ERROR: $$FAILED test(s) failed." && exit 1; }; \ rm -f $$LINTLOG
# This include must come _before_ the pattern rules below!
Added: trunk/util/lint/lint-000-license-headers ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/util/lint/lint-000-license-headers Fri Nov 19 11:16:43 2010 (r6097) @@ -0,0 +1,34 @@ +#!/bin/sh +# This file is part of the coreboot project. +# +# Copyright (C) 2010 coresystems GmbH +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +# +# DESCR: Check that all files in src/ and util/ have valid license headers + +LC_ALL=C export LC_ALL +find src util -name .svn -type d -prune -o \ + -name README -prune -o \ + -name LICENSE -prune -o \ + -name TODO -prune -o \ + -name COPYING -prune -o \ + -name microcode-*.h -prune -o \ + -name *.[18] -prune -o \ + -name romcc -type d -prune -o \ + -name crossgcc -type d -prune -o \ + -type f -exec \ + grep -L "51 Franklin St, Fifth Floor, Boston" {} + | \ + sed -e "s,^.*$,File & has no valid GPL header.,"
Modified: trunk/util/lint/lint-001-no-global-config-in-romstage ============================================================================== --- trunk/util/lint/lint-001-no-global-config-in-romstage Fri Nov 19 01:29:32 2010 (r6096) +++ trunk/util/lint/lint-001-no-global-config-in-romstage Fri Nov 19 11:16:43 2010 (r6097) @@ -1,5 +1,23 @@ #!/bin/sh -# DESCR: Check that no symbols #defined in any romstage.c is used elsewhere +# This file is part of the coreboot project. +# +# Copyright (C) 2010 coresystems GmbH +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; version 2 of the License. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +# DESCR: Check that no symbol #defined in any romstage.c is used elsewhere + DEFINES=`grep "#define" src/mainboard/*/*/romstage.c |sed 's,.*#define[\t ]([^\t ]*)[\t ].*,\1,' | grep -v "(" | sort -u` SCANBUCKET=`mktemp` LC_ALL=C export LC_ALL