Re: [coreboot] [PATCH] Support for MSI MS-6156

[Myles Watson]

On Tue, Oct 13, 2009 at 12:01 PM, Uwe Hermann  wrote:
> As everyone is committing new boards today, I don't want to be left behind.
> So here goes one more board for today (yet-another-440BX).
>
> Boot-tested to a Linux prompt successfully.

Looks good.  Only picky things:
1. You used spaces for indentation instead of tabs in devicetree.cb
     It looks good, but I think it's good to be standard.
> Kconfig only, I didn't bother adding oldconfig files anymore.

2.  The downside is that you don't get run with abuild, so if someone
breaks the build you won't know.  Of course it's similar enough to
other boards that most likely it won't happen.

Acked-by: Myles Watson

Thanks,
Myles