Re: [coreboot] Flashrom jedec probe patch + AT29C010A logs

[Maciej Pijanka]

On 02/06/2009, Carl-Daniel Hailfinger  wrote:
> On 02.06.2009 21:57, Maciej Pijanka wrote:
> > Hello
> >
> > Carl-Daniel pointed me to easy tasks list in wiki, i tried to prepare some
> > patch that allow to add probe_timing information (int uS value) used
> > by jedec_probe (patch attached)
>
> Thanks for the patch.
> Review follows:
> probe_49fl00x is a wrapper for probe_jedec. Those chips need the
>
> probe_timing parameter as well.
> probe_sst_fwhub has the same problem.
> If someone forgets the probe_timing parameter, it will be zero. That's
>
> bad for almost all chips. Maybe add an explicit check for nonzero delays?
> It might be best if every chip definition got that probe_timing
>
> parameter. Other probe functions could use similar delay info.
> SPI chips want zero delay.

fixed patch in attachment

best regards
Maciej Pijanka