Re: [coreboot] Coreboot bug?

[Myles Watson]

On Wed, Nov 11, 2009 at 1:50 PM, ron minnich  wrote:
> It's not my favorite piece of code.

:)
> > unsigned char option_table[] = {
> >        0xc8,0x00,0x00,0x00,0x88,0x04,0x00,0x00,0x0c,0x00,
>
> Second 32 bits 0x88,0x04,0x00,0x00 is the length. We're small endian.
> So it's 0x488 or 1160 bytes. Does that match?

Yes, it matches.  There are 116 10-byte lines.
> So this struct:
> > struct lb_record {
> >        uint32_t tag;           /* tag ID */
> >        uint32_t size;          /* size of record (in bytes) */
> > };
>
> is a header of a variable length record.

Thanks.  I should have looked a little farther before I asked.  The
warning looked ominous and it wasn't obvious what the code was doing.

Myles