Re: [coreboot] [PATCH] buildrom: openvsa Makefile fix

[Ward Vandewege]

On Wed, Dec 10, 2008 at 10:06:24AM -0700, Abhishek Kulkarni wrote:
> On Wed, Dec 10, 2008 at 10:00 AM, Ward Vandewege  wrote:
>  On Wed, Dec 10, 2008 at 09:50:12AM -0700, Abhishek Kulkarni wrote:
>  >    openvsa.inc has no OPENVSA_LOG_DIR target, and considering that
>  >    $(SOURCE_DIR)/$(OPENVSA_TARBALL) creates the LOG_DIR we don't need
>  to add
>  >    dependency on the LOG_DIR.
>
>  Actually, let's do it the other way around and remove that
>   @ mkdir -p $(OPENVSA_LOG_DIR)
>
>  while keeping the dependency on $(OPENVSA_LOG_DIR).
>
>  That's cleaner. OK?
>
> Sure, makes sense.
>
> Also, most of the main targets already have a dependency on the LOG_DIR
>    targets. Is there a specific reason to add it to the TARBALL_TARGET too?

Yes:

@ $(BIN_DIR)/fetchsvn.sh $(OPENVSA_URL) $(SOURCE_DIR)/openvsa \
         $(OPENVSA_TAG) $@ > $(OPENVSA_FETCH_LOG) 2>&1

$(OPENVSA_FETCH_LOG) is made up from $(OPENVSA_LOG_DIR), so it has to exist
before this target is called.
> Corrected patch below:

Can you sign it off as per the guidelines at

http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure

In fact that entire page is good reading :)

Thanks,
Ward.