Author: stepan Date: 2008-11-20 20:26:16 +0100 (Thu, 20 Nov 2008) New Revision: 3762
Modified: trunk/coreboot-v2/src/mainboard/tyan/s2895/cache_as_ram_auto.c Log: OK, people, watch this.
This is a school book example of why trivial indent patches just suck big time.
This error was introduced by a trivial self-acked indent patch and was never detected (because of a missing Config-abuild.lb)
So, indenting the code for no reason can make it a lot worse (read: break it) instead of improving it.
I ask everyone to keep this in mind when going on indent-frenzy again.
Signed-off-by: Stefan Reinauer stepan@coresystems.de Acked-by: Stefan Reinauer stepan@coresystems.de
Modified: trunk/coreboot-v2/src/mainboard/tyan/s2895/cache_as_ram_auto.c =================================================================== --- trunk/coreboot-v2/src/mainboard/tyan/s2895/cache_as_ram_auto.c 2008-11-19 13:42:14 UTC (rev 3761) +++ trunk/coreboot-v2/src/mainboard/tyan/s2895/cache_as_ram_auto.c 2008-11-20 19:26:16 UTC (rev 3762) @@ -222,9 +222,8 @@ #if USE_FALLBACK_IMAGE == 1 failover_process(bist, cpu_init_detectedx); #endif -#endif real_main(bist, cpu_init_detectedx); - +#endif }
#if USE_FAILOVER_IMAGE==0