On Sun, Feb 25, 2018 at 04:25:23AM -0600, Timothy Pearson wrote:
On 02/25/2018 02:18 AM, Mike Banon wrote:
Any particular reason those patches were not upstreamed?
Because a person who submitted these patches did not fix some problems,
I'm aware of this. Upstreaming was never part of the original funding effort and I haven't had any spare time to try to work on it; been working on several other projects in what little spare time I have had over the past year. If anyone else would like to apply the recommended cleanups and resubmit I'm fine with that.
I've taken a swing at pushing a patch to address reviewer comments. First time submitting to CoreBoot, fingers crossed :)
https://review.coreboot.org/#/c/coreboot/+/19820/
Best, James