Re: [coreboot] buildrom: Add support for ASUS A8V-E SE

[Jordan Crouse]

On 21/04/08 23:09 +0200, Uwe Hermann wrote:
> See patch.
> Uwe.
>
> http://www.hermann-uwe.de  | http://www.holsham-traders.de
> http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
> Initial buildrom support for the ASUS A8V-E SE board.
> This code also works (and has been tested) on ASUS A8V-E Deluxe.
>
> So far only FILO and Etherboot have been tested (Etherboot loads
> fine but doesn't work as the old version we use in buildrom doesn't
> support the onboard NIC on this board yet).
>
> Signed-off-by: Uwe Hermann

This looks fine to me.
Acked-by: Jordan Crouse
> Index: config/platforms/asus_a8v-e_se.conf
>
> --- config/platforms/asus_a8v-e_se.conf	(Revision 0)
> +++ config/platforms/asus_a8v-e_se.conf	(Revision 0)
> @@ -0,0 +1,52 @@
> +# Support for the ASUS A8V-E SE board
>
> +#### Platform configuration
>
> +CC=gcc
> +STRIP=strip
> +AS=as
>
> +ifeq ($(CONFIG_TARGET_64BIT),y)
> +TARGET_ARCH=x86_64
> +CFLAGS_platform =
> +else
> +TARGET_ARCH=i686
> +CFLAGS_platform =
> +endif
>
> +# Targets
>
> +# TODO
> +# KERNEL_MK=$(PACKAGE_DIR)/kernel/asus_a8v-e_se.mk
> +CBV2_MK=$(PACKAGE_DIR)/coreboot-v2/asus_a8v-e_se.mk
>
> +# kernel configuration (for LAB)
>
> +# TODO
> +# KERNEL_VERSION=2.6.22.2
> +# 
> +# ifeq ($(CONFIG_TARGET_64BIT),y)
> +# $(error You must specify a kernel configuration for 64 bit)
> +# else
> +# KERNEL_CONFIG=$(PACKAGE_DIR)/kernel/conf/defconfig-asus_a8v-e_se
> +# endif
>
> +UCLIBC_ARCH=$(TARGET_ARCH)
>
> +# Etherboot configuration
>
> +ETHERBOOT_ARCH=i386
>
> +# coreboot configuration
>
> +COREBOOT_VENDOR=asus
> +COREBOOT_BOARD=a8v-e_se
> +CBV2_CONFIG=Config.lb
> +CBV2_PAYLOAD_FILE_EXT=elf
> +CBV2_TDIR=asus_a8v-e_se
> +CBV2_TAG=3241
>
> +# FILO configuration
>
> +FILO_CONFIG=asus_a8v-e_se-Config
> Index: config/platforms/platforms.conf
>
> --- config/platforms/platforms.conf	(Revision 150)
> +++ config/platforms/platforms.conf	(Arbeitskopie)
> @@ -12,6 +12,7 @@
>  PLATFORM-$(CONFIG_PLATFORM_DB800) = db800.conf
>  PLATFORM-$(CONFIG_PLATFORM_DBE61) = dbe61.conf
>  PLATFORM-$(CONFIG_PLATFORM_GA_M57SLI_S4) = m57sli.conf
> +PLATFORM-$(CONFIG_PLATFORM_ASUS_A8V_E_SE) = asus_a8v-e_se.conf
>  PLATFORM-$(CONFIG_PLATFORM_TYAN_S2881) = tyan-s2881.conf
>  PLATFORM-$(CONFIG_PLATFORM_TYAN_S2882) = tyan-s2882.conf
>  PLATFORM-$(CONFIG_PLATFORM_TYAN_S2891) = tyan-s2891.conf
> Index: config/platforms/Config.in
> ===================================================================
> --- config/platforms/Config.in	(Revision 150)
> +++ config/platforms/Config.in	(Arbeitskopie)
> @@ -12,6 +12,10 @@
>  config VENDOR_ARTEC_GROUP
>    bool "Artec Group"
>
> +config VENDOR_ASUS
> bool "ASUS"
> depends COREBOOT_V2
>
> config VENDOR_ADVANCED_DIGITAL_LOGIC
>    bool "Advanced Digital Logic"
>
> @@ -79,6 +83,13 @@
>         select PLATFORM
>         select PLATFORM_SUPPORT_64BIT
>
> +config PLATFORM_ASUS_A8V_E_SE
>   bool "ASUS A8V-E SE"
>   depends VENDOR_ASUS
>   depends COREBOOT_V2
>   select PLATFORM
>   select PLATFORM_SUPPORT_64BIT
>
> config PLATFORM_GA_2761GXDK
>    bool "GIGABYTE GA-2761GXDK"
>    depends on VENDOR_GIGABYTE
> Index: packages/filo/conf/asus_a8v-e_se-Config
> ===================================================================
> --- packages/filo/conf/asus_a8v-e_se-Config	(Revision 0)
> +++ packages/filo/conf/asus_a8v-e_se-Config	(Revision 0)
> @@ -0,0 +1,17 @@
> +USE_GRUB = 1
> +MENULST_FILE = "hda2:/boot/grub/menu.lst"
> +IDE_DISK = 1
> +IDE_DISK_POLL_DELAY = 1
> +SLOW_SATA = 1
> +USB_DISK = 1
> +VGA_CONSOLE = 1
> +PC_KEYBOARD = 1
> +SERIAL_CONSOLE = 1
> +SERIAL_IOBASE = 0x3f8
> +SERIAL_SPEED = 115200
> +FSYS_EXT2FS = 1
> +FSYS_ISO9660 = 1
> +ELTORITO = 1
> +SUPPORT_PCI = 1
> +PCI_BRUTE_SCAN = 1
> +LINUX_LOADER = 1
> Index: packages/coreboot-v2/asus_a8v-e_se.mk
> ===================================================================
> --- packages/coreboot-v2/asus_a8v-e_se.mk	(Revision 0)
> +++ packages/coreboot-v2/asus_a8v-e_se.mk	(Revision 0)
> @@ -0,0 +1,41 @@
> +ifeq ($(CONFIG_PLATFORM),y)
> +ifeq ($(CBV2_TAG),)
> +$(error You need to specify a version to pull in your platform config)
> +endif
> +endif
>
> +CBV2_PATCHES=
>
> +# ifeq ($(CONFIG_PAYLOAD_KERNEL),y)
> +# 	CBV2_CONFIG = Config-lab.lb
> +# 	CBV2_PAYLOAD_FILE_EXT = elf.lzma
> +# endif
> +# 
> +# ifeq ($(CONFIG_PAYLOAD_LAB),y)
> +# 	CBV2_CONFIG = Config-lab.lb
> +# 	CBV2_PAYLOAD_FILE_EXT = elf.lzma
> +# endif
>
> +CBV2_BASE_DIR=svn
> +CBV2_URL=svn://coreboot.org/repos/trunk/coreboot-v2
> +CBV2_TARBALL=coreboot-svn-$(CBV2_TAG).tar.gz
> +CBV2_PAYLOAD_TARGET=$(CBV2_BUILD_DIR)/payload.$(CBV2_PAYLOAD_FILE_EXT)
> +TARGET_ROM = $(COREBOOT_VENDOR)-$(COREBOOT_BOARD).rom
>
> +include $(PACKAGE_DIR)/coreboot-v2/coreboot.inc
>
> +$(SOURCE_DIR)/$(CBV2_TARBALL):
> @ echo "Fetching the coreboot code..."
> @ mkdir -p $(SOURCE_DIR)/coreboot
> @ $(BIN_DIR)/fetchsvn.sh $(CBV2_URL) $(SOURCE_DIR)/coreboot \
> $(CBV2_TAG) $(SOURCE_DIR)/$(CBV2_TARBALL) \
> > $(CBV2_FETCH_LOG) 2>&1
>
> +$(OUTPUT_DIR)/$(TARGET_ROM): $(CBV2_OUTPUT)
> @ mkdir -p $(OUTPUT_DIR)
> @ cat $(CBV2_OUTPUT) > $@
>
> +coreboot: $(OUTPUT_DIR)/$(TARGET_ROM)
> +coreboot-clean: generic-coreboot-clean
> +coreboot-distclean: generic-coreboot-distclean
>