Hung-Te Lin (hungte@chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2316
-gerrit
commit dc594aa1647d85e8e5292a356faff2c3dcc6b4b7 Author: Hung-Te Lin hungte@chromium.org Date: Thu Feb 7 21:15:42 2013 +0800
armv7/snow: Remove redundant I2C initialization calls in bootblock.
The I2C initialization (on component MAX77688) is already done in power_init, so we should not need an explicit call inside bootblock.
Verified to boot on armv7/snow.
Change-Id: I68c248a8b5fee4ab838b2fb708649e112559cc41 Signed-off-by: Hung-Te Lin hungte@chromium.org --- src/mainboard/google/snow/bootblock.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/src/mainboard/google/snow/bootblock.c b/src/mainboard/google/snow/bootblock.c index 64b12c6..8390ae8 100644 --- a/src/mainboard/google/snow/bootblock.c +++ b/src/mainboard/google/snow/bootblock.c @@ -23,15 +23,12 @@ #include <cbfs.h> #include <uart.h> #include <console/console.h> -#include <device/i2c.h> #include <cpu/samsung/exynos5250/clk.h> #include <cpu/samsung/exynos5250/dmc.h> #include <cpu/samsung/exynos5250/periph.h> #include <cpu/samsung/exynos5250/clock_init.h> #include <src/cpu/samsung/exynos5250/power.h> -#include <drivers/maxim/max77686/max77686.h>
-#define I2C0_BASE 0x12c60000 #endif
void bootblock_mainboard_init(void); @@ -40,8 +37,6 @@ void bootblock_mainboard_init(void) struct mem_timings *mem; struct arm_clk_ratios *arm_ratios;
- i2c_set_early_reg(I2C0_BASE); - i2c_init(CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE); power_init(); mem = get_mem_timings(); arm_ratios = get_arm_clk_ratios();