Re: [coreboot] [PATCH] exit from self-refresh on AMD K8 CPUs (pre revF)

[Peter Stuge]

Rudolf Marek wrote:
> On 4.12.2010 20:55, Rudolf Marek wrote:
> > Hello,
> >
> > Following patch adds support to bring out the memory out of self refresh
> > when doing resume.
> >
> > Signed-off-by: Rudolf Marek
> >
> > The patch is based on my 2008 patch.
>
> Removed compilation warning & refreshed to match current tree.

Acked-by: Peter Stuge
> +++ coreboot/src/northbridge/amd/amdk8/raminit.c	2010-12-12 00:42:07.000000000 +0100

..
> +#if 0
> 	/* the registers are marked read-only but code zeros them */
> dcl &= ~(DCL_MemClrStatus | DCL_DramEnable);
> pci_write_config32(ctrl[i].f2, DRAM_CONFIG_LOW, dcl);
>
> +#endif

Why not just remove the code?