Re: [coreboot] Share my code of running vgabios(in CBFS) in seabios when rusume from s3.

[Kevin O'Connor]

On Sat, Jul 04, 2009 at 02:09:28PM +0200, Peter Stuge wrote:
> Kevin O'Connor wrote:
> > void
> > s3_resume_vga_init()
> > {
> >     if (!CONFIG_S3_RESUME_VGA_INIT)
> >         return;
> >     struct rom_header *rom = (void*)OPTION_ROM_START;
> >     if (! is_valid_rom(rom))
> >         return;
> >     callrom(rom, OPTION_ROM_INITVECTOR, 0);
> > }
>
> Would this remove the need for the acpi=s3_bios kernel parameter?
>
> I guess this is doing the same thing?

I think it is doing the same thing.  I committed the above code to
seabios, but I left it disabled by default.

Jason, if you use "acpi=s3_bios" does it work without running the rom
from seabios?

-Kevin