Re: [coreboot] [PATCH] coreboot: Don't loop forever waiting for HDA codecs

[Peter Stuge]

Uwe Hermann wrote:
> Make the hardcoded "1" into a nice, descriptive #define?

..
> Make the hardcoded "2" and "3" into nice, descriptive #defines?
> Also the 0x68 register could be a #define.

I don't know. While they are good for documentation purposes they
cause a sometimes annyoing indirection when reading the code..

//Peter