RE: [LinuxBIOS] Config file dependencies

[Li-Ta Lo]

On Thu, 2005-10-27 at 13:45 -0700, Lu, Yinghai wrote:
> No
> CONFIG_USE_INIT==0 is very useful for debug.

Why??
> CONFIG_USE_INIT==1 is something ppc car using...

AFIAK, the way you are using USE_INIT is totally different from what 
Greg is doing on PPC. I am not an expert on this issue but I believe
the only common thing in these two is the same macro name. Greg, can
you have some comment on this?
> Auto.c and cache_as_ram_auto.c is very different
> cache_as_ram_auto include failover.c

Why do you do that? Why don't you have cache_as_ram_failover.c too?
> later cache_as_ram_auto will have struct sys_info sysinfox, and it
>
> will include every info include dimm.....and we don't need to keep read
> smbus and pci conf space for....

Any reason it has to be in cache_as_ram_auto only?
> YH
>
> -----Original Message-----
> From: Li-Ta Lo [mailto:[e-mail]] 
> Sent: Thursday, October 27, 2005 1:22 PM
> To: Lu, Yinghai
> Cc: Stefan Reinauer; LinuxBIOS
> Subject: RE: [LinuxBIOS] Config file dependencies
>
> On Thu, 2005-10-27 at 11:11 -0700, Lu, Yinghai wrote:
> > If CONFIG_USE_INIT == 0, the cache_as_ram_auto.c will be compiled to
> > auto.inc. ---> part of crt0.s---> part of linuxbios_rom
> >
> > If CONFIG_USE_INIF == 1, the cache_as_ram_auto.c will be compiled to
> > auto.o and be linked with memcpy.o....and auto.o and memcpy.o --->
> > init.o
> > And init.o ---> part of linuxbios_rom...
>
> Is there any reason we need two different ways to do it? If both of them
> are as good, can we drop one and support just the other?
>
> BTW, after reading your patch, I found there is very little difference 
> between auto.c and cache_as_ram_auto.c. Most of the differences are in
> the included files, can we merge auto.c and cache_as_ram_auto.c?
> > YH
> >
> > -----Original Message-----
> > From: [e-mail]
> > [mailto:[e-mail]] On Behalf Of Li-Ta Lo
> > Sent: Thursday, October 27, 2005 10:31 AM
> > To: Stefan Reinauer
> > Cc: LinuxBIOS
> > Subject: Re: [LinuxBIOS] Config file dependencies
> >
> > On Thu, 2005-10-27 at 09:26 +0200, Stefan Reinauer wrote:
> > > Hi,
> > > > @@ -130,10 +130,10 @@
> > > >  ##
> > > >  ## enable CACHE_AS_RAM specifics
> > > >  ##
> > > > -default USE_DCACHE_RAM=1
> > > > +default USE_DCACHE_RAM=0
> > > >  default DCACHE_RAM_BASE=0xcf000
> > > >  default DCACHE_RAM_SIZE=0x1000
> > > > -default CONFIG_USE_INIT=1
> > > > +default CONFIG_USE_INIT=0
> > >
> > > The config files have a number of dependencies like the above.
> > > USE_DCACHE_RAM needs CONFIG_USE_INIT otherwise it won't work.
> >
> > That's something I try to figure out. If DCACHE_RAM needs USE_INIT,
> > why we still have
> >
> > #if CONFIG_USE_INIT == 0
> > #include "lib/memcpy.c"
> > #endif
> >
> > in the src/mainboard/tyan/s2895/cache_as_ram_auto.c ?
> > > Should we put this dependency in another place? Keeping such 
> > > things in mind should be part of the LinuxBIOS configuration, 
> > > not the LinuxBIOS (mainboard) developer..
> > >
> > > Stefan