Re: [LinuxBIOS] [PATCH] v3: fix compilation due to multiple definitions of printk

[Stefan Reinauer]

* Carl-Daniel Hailfinger  [071122 21:44]:
> The introduction of the _SHARED macros had one flaw: If multiple files
> had _SHARED defined during compilation, each of them would contain an
> assignment of stage0_printk to *printk. During linking, this caused
> errors as multiple definitions of printk existed.
> Make sure _SHARED alone gives you only the printk prototype, and iff
> _MAINOBJECT is defined as well, include the assignment.
>
> Signed-off-by: Carl-Daniel Hailfinger

I like it, but I suggest to simplify the code further.

On top of your sign-off, add
Signed-off-by: Stefan Reinauer