Re: [coreboot] r3416 - trunk/util/flashrom

[Stefan Reinauer]

[e-mail] wrote:
> Author: hailfinger
> Date: 2008-07-07 01:04:01 +0200 (Mon, 07 Jul 2008)
> New Revision: 3416
>
> Modified:
>    trunk/util/flashrom/flash.h
>    trunk/util/flashrom/flashchips.c
> Log:
> r3415 removed symbolic constants for device IDs by accident.
> flash.h is a database of known IDs, whereas flashchips.c is a database
> of chips for which support has been implemented. Keep it that way.
>
> Trivial.

NACK. This was done on purpose, not by accident. As discussed before, we
will not pursue the useless facility of defines for those IDs anymore
because they serve no purpose.

Stefan