Re: [coreboot] PnP device enabling fail

[Keith Hui]

> On Wed, Mar 24, 2010 at 8:56 AM, Stefan Reinauer wrote:
> > On 3/24/10 2:04 PM, Myles Watson wrote:
> > > > I switched back to my P2B-LS and tried the onboard SCSI now that I got
> > > > the keyboard going.
> > >
> > > So why did that change work if pnp_enable_resources was already doing the
> > > same thing?
> >
> > I seem to remember the southbridge driver had to contain some code to
> > make sure the pnp and i2c devices hanging off it are initialized
> > correctly. Maybe the device allocator does not try to call
> > pnp_enable_resources for the ASUS P2B?
>
> That could be.  I just looked at the superio code, and I'm not sure it looks
> right.  I'd like to see the log with this patch applied.  If it's correct,
> it should be called for each enabled PNP device.
> Index: svn/src/devices/pnp_device.c
>
> --- svn.orig/src/devices/pnp_device.c
> +++ svn/src/devices/pnp_device.c
> @@ -145,6 +145,7 @@ void pnp_set_resources(device_t dev)
>
> void pnp_enable_resources(device_t dev)
>  {
> printk(BIOS_DEBUG, "%s: %s\n", __func__, dev_path(dev));
>
> pnp_set_logical_device(dev);
>     pnp_set_enable(dev, 1);
>  }
>
> Thanks,
> Myles

Not looking good. I don't think pnp_enable_resources() is being called
for any device.

Here is a diff of the boot log from power on to Fedora 11 login
prompt, between two runs with and without your patch:

1c1
< coreboot-4.0-r5287M Wed Mar 24 22:53:16 EDT 2010 starting...
---
> coreboot-4.0-r5287M Wed Mar 24 23:37:38 EDT 2010 starting...

22c22
< coreboot-4.0-r5287M Wed Mar 24 22:53:16 EDT 2010 booting...
---
> coreboot-4.0-r5287M Wed Mar 24 23:37:38 EDT 2010 booting...

25c25
< end 85a9b49f, start 2eff06c7
---
> end 85b1a975, start 2f06fb39

606c606
< Wrote coreboot table at: 17ff1400 - 17ff1594  checksum c585
---
> Wrote coreboot table at: 17ff1400 - 17ff1594  checksum be7e

617c617
< CBFS: follow chain: fffc0000 + 38 + 83e4 + align -> fffc8440
---
> CBFS: follow chain: fffc0000 + 38 + 83fc + align -> fffc8440

642,643c642,643
<      elf_boot_notes = 0x0010f218
< adjusted_boot_notes = 0x17fdb218
---
>  elf_boot_notes = 0x0010f25c
>
> adjusted_boot_notes = 0x17fdb25c

754c754
< Detected 1002.242 MHz processor.
---
> Detected 1002.299 MHz processor.

773c773
< Calibrating delay loop (skipped), value calculated using timer
frequency.. 2004.48 BogoMIPS (lpj=1002242)
---
> Calibrating delay loop (skipped), value calculated using timer frequency.. 2004.59 BogoMIPS (lpj=1002299)

797c797
< Total of 1 processors activated (2004.48 BogoMIPS).
---
> Total of 1 processors activated (2004.59 BogoMIPS).

801c801
< Time: 23:30:43  Date: 03/24/10
---
> Time: 23:57:03  Date: 03/24/10

839c839
< type=2000 audit(1269473443.491:1): initialized
---
> type=2000 audit(1269475023.491:1): initialized

914c914
<   Magic number: 2:703:555
---
> Magic number: 2:668:1010

917c917
< Clocksource tsc unstable (delta = 182965548 ns)
---
> Clocksource tsc unstable (delta = 177928007 ns)

Any differences after this point are about ext3, SELinux, udev and
such, and doesn't concern us.

See attached for the full log.

It could also be the same issue as this problem: I need to remove the
onboard LAN device from devicetree.cb to get it to work. That piece is
PCI though, so if the two are related, we have a bigger problem.

Is it time I or someone log this into the issue tracker?

Regards
Keith