Re: [coreboot] ASRock E350M1: GRUB payload does not create AHCI device

[Paul Menzel]

Dear coreboot folks,

Am Sonntag, den 31.03.2013, 20:55 +0200 schrieb Paul Menzel:
> although this is a GRUB problem, I am posting this to the coreboot list
> as it is in the GRUB payload and I am not subscribed to the GRUB list.

I was told to take this issue up to the GRUB lists [1], but I do not
know which one is appropriate. help-grub, bug-grub or grub-devel?
Vladimir, which list should I sent a message about this problem to?
> Currently using GRUB revision 4778 as a payload [1], loading the module
> `ahci` I see the following errors (formatted serial output, “garbled”
> one at the end) on the AMD SB800 based ASRock E350M1 [2].
>     grub> set debug=ahci,ata
>     grub> insmod ahci
>     disk/ahci.c:291: Requesting AHCI ownership
>     disk/ahci.c:294: Waiting for BIOS to give up ownership
>     disk/ahci.c:305: AHCI ownership obtained
>     disk/ahci.c:311: AHCI is in compat mode. Switching
>     disk/ahci.c:357: 6 AHCI ports
>     disk/ahci.c:367: status 0:123
>     disk/ahci.c:184: found device ahci0 (port 0)
>     disk/ahci.c:225: couldn't start CR
>     grub> insmod ata
>     grub> insmod mdraid
>     grub> insmod mdraid09
>     grub> ls
>     (memdisk)
>
> SeaBIOS has no problems finding the attached ATA drive.

Kevin answered on IRC, that SeaBIOS’s AHCI code just follows the
specification.

Vladimir, noticed that SeaBIOS sets higher timeouts than GRUB, but
*locally* doing

revno: 4779
        committer: Paul Menzel 
        branch nick: grub
        timestamp: Sun 2013-03-31 23:32:18 +0200
        message:
          Increase endtime to get DMA started
        diff:
        === modified file 'grub-core/disk/ahci.c'
        --- grub-core/disk/ahci.c       2013-03-25 09:32:56 +0000
        +++ grub-core/disk/ahci.c       2013-03-31 21:32:18 +0000
        @@ -193,7 +193,7 @@
               }

dev->hba->ports[dev->port].command &= ~GRUB_AHCI_HBA_PORT_CMD_ST;
        -  endtime = grub_get_time_ms () + 1000;
        +  endtime = grub_get_time_ms () + 10000;
           while ((dev->hba->ports[dev->port].command & GRUB_AHCI_HBA_PORT_CMD_CR))
             if (grub_get_time_ms () > endtime)
               {

to increase the timeout did unfortunately not have any effect and the
same error messages were printed.
> If more information is needed, please tell me what and how I can get it,
> and I will try to provide it.

Thanks,

Paul
> [1] http://www.coreboot.org/GRUB2
> [2] http://www.coreboot.org/ASRock_E350M1

[3] http://www.gnu.org/software/grub/grub-mailinglist.html
> grub> ins   set debug=ahci,ata
> grub> insom  mot d ahci
> disk/ahci.c:291: Requesting AHCI ownership
> disk/ahci.c:294: Waiting for BIOS to give up ownership
> disk/ahci.c:305: AHCI ownership obtained
> disk/ahci.c:311: AHCI is in compat mode. Switching
> disk/ahci.c:357: 6 AHCI ports
> disk/ahci.c:367: status 0:123
> disk/ahci.c:184: found device ahci0 (port 0)
> disk/ahci.c:225: couldn't start CR
> grub> insmod ata
> grub> insomd   mod mdraid
> grub> insmod mdraid09
> grub> ls
> (memdisk)