On Wed, Apr 11, 2007 at 08:44:43PM +0200, svn@openbios.org wrote:
Jeremy Jackson wrote: I'm guessing nobody has tried compiling it with 64bit userspace?
Patch makes it compile cleanly and stops a "SEGV instead of working" issue.
I also added a few checks for errors on system calls.
Signed-off-by: Jeremy Jackson jerj@coplanar.net
Reworked and Acked-by: Stefan Reinauer stepan@coresystems.de
I think this should either be
Signed-off-by: Stefan Reinauer stepan@coresystems.de Acked-by: Stefan Reinauer stepan@coresystems.de
(sign-off because you modified the code, acked-by because you acked it and it needs an ack before it can be committed)
or:
You repost the modified patch for review (if your modifications are nontrivial), with the original sign-off and your new sign-off and waiting for an ack:
Signed-off-by: Jeremy Jackson jerj@coplanar.net Signed-off-by: Stefan Reinauer stepan@coresystems.de
(See also my other post, answering Peter's question from a few days ago)
all: getpir checkpir
- ./checkpir
Don't do this please. If I type 'make' I don't expect the build process to _run_ the resulting binary for me (won't work anyways as it needs root access and you usually don't compile as root).
+irq_tables.c: getpir
- ./getpir
See above.
-test: checkpir
- ./checkpir ;\
- exit 0;
An extra target such as this ('test' or 'run' or so) would be fine, though.
Uwe.