[coreboot] Re: QEMU x86 i440fx/piix4 build fails for >= 32MB ROMs - Assertion IS_HOST_SPACE_ADDRESS(host_space_address) failed

[Paul Menzel]

Dear Mike,

Am 23.06.22 um 09:49 schrieb Mike Banon:
> If I use a default config for i440fx/piix4, building a 16MB ROM works
> fine, but 32MB or 64MB doesn't work anymore:
>
> ...
>      CC         postcar/southbridge/intel/common/rtc.o
>      LINK       cbfs/fallback/postcar.debug
>      OBJCOPY    cbfs/fallback/romstage.elf
>      CREATE     build/mainboard/emulation/qemu-i440fx/cbfs-file.vqaXlP.out (from /home/my_custom_path_to/coreboot/.config)
>      CC+STRIP   src/lib/cbfs_master_header.c
>      OBJCOPY    cbfs/fallback/bootblock.elf
>      OBJCOPY    bootblock.raw.elf
>      OBJCOPY    bootblock.raw.bin
> Created CBFS (capacity = 33553892 bytes)
>      BOOTBLOCK
>      CBFS       cbfs_master_header
>      CBFS       fallback/romstage
> cbfstool: /home/my_custom_path_to/coreboot/util/cbfstool/cbfstool.c:1145: cbfstool_convert_mkstage: Assertion `IS_HOST_SPACE_ADDRESS(host_space_address)' failed.
> make: *** [Makefile.inc:1116: build/coreboot.pre] Aborted

Thank you for the report. It looks like a regression of commit 
20ad36547e25 (cbfstool: Do host space address conversion earlier when 
adding files) [1].

Building a 32 MB ROM also fails for emulation/qemu-q35 
(`CONFIG_BOARD_EMULATION_QEMU_X86_Q35=y`).

Kind regards,

Paul

[1]: https://review.coreboot.org/c/coreboot/+/60018