coreboot

coreboot@coreboot.org

6 participants
39687 discussions

[coreboot - Bug #332] (New) I selected payload Tianocore Upstream (not UEFIPayload) but its still using MrChromebox UEFIPayload files?
by coreboot＠fe80.eu 30 Dec '21

30 Dec '21

Issue #332 has been reported by xinhua wang. ---------------------------------------- Bug #332: I selected payload Tianocore Upstream (not UEFIPayload) but its still using MrChromebox UEFIPayload files? https://ticket.coreboot.org/issues/332 * Author: xinhua wang * Status: New * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- make V=1 -d Cloning Tianocore from Git Reaping winning child 0x559abd8daf20 PID 142498 git clone --branch uefipayload_202107 https://github.com/mrchromebox/edk2 /mnt/cb-trying-upstream/coreboot/payloads/external/tianocore/tianocore; \ cd /mnt/cb-trying-upstream/coreboot/payloads/external/tianocore/tianocore; \ git remote add upstream https://github.com/tianocore/edk2 Live child 0x559abd8daf20 (/mnt/cb-trying-upstream/coreboot/payloads/external/tianocore/tianocore) PID 142499 Cloning into '/mnt/cb-trying-upstream/coreboot/payloads/external any ideas, thx -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Feature #331] (New) Add detail wiki how to use oxford serial card?
by coreboot＠fe80.eu 30 Dec '21

30 Dec '21

Issue #331 has been reported by xinhua wang. ---------------------------------------- Feature #331: Add detail wiki how to use oxford serial card? https://ticket.coreboot.org/issues/331 * Author: xinhua wang * Status: New * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- Add detail wiki how to use oxford serial card? For example, early pci settings.. how to determine what mmio to use, etc for the green one, I only see [ 0.364949] 0000:01:00.0: ttyS4 at MMIO 0x83401000 (irq = 16, base_baud = 4000000) is a 16C950/954 [ 0.365132] 0000:01:00.0: ttyS5 at MMIO 0x83401200 (irq = 16, base_baud = 4000000) is a 16C950/954 then I am lost at what to do, I tried plug in 0x83401000, and select 0 index but it does not do anything I tested the ttyS4 with another computer and my cable, adapter works. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Feature #330] (New) Add support for the red oxford debug card 1415:c120
by coreboot＠fe80.eu 30 Dec '21

30 Dec '21

Issue #330 has been reported by xinhua wang. ---------------------------------------- Feature #330: Add support for the red oxford debug card 1415:c120 https://ticket.coreboot.org/issues/330 * Author: xinhua wang * Status: New * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- Add support for the red oxford debug card 1415:c120 The green one is correct pciid (same as wiki, but the red one is different), there was no mention was this and got tricked and lost money buying the wrong one. (unless there is some way to add support) thx -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Feature #329] (New) Add progress feature so it doesn't look "hung" when running make on slow internet connections
by coreboot＠fe80.eu 30 Dec '21

30 Dec '21

Issue #329 has been reported by xinhua wang. ---------------------------------------- Feature #329: Add progress feature so it doesn't look "hung" when running make on slow internet connections https://ticket.coreboot.org/issues/329 * Author: xinhua wang * Status: New * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- edit the makefile.inc so the submodules chromeec, etc will show something (I had to use V=1 and -d to show it), forgetthis:=$(if $(GIT),$(shell git submodule update --progress --init $(quiet_errors))) forgetthis:=$(if $(GIT),$(shell git submodule update --init --progress )) (add --progress) when i ran make it just hang before for hours after I found its download at 60kb/s thats why no idea how to integrate that or make it as default, as you would need V=1 and -d too ? -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Feature #328] (New) Add RAM disk/filesystem in SPI flash for tianocore
by coreboot＠fe80.eu 30 Dec '21

30 Dec '21

Issue #328 has been reported by xinhua wang. ---------------------------------------- Feature #328: Add RAM disk/filesystem in SPI flash for tianocore https://ticket.coreboot.org/issues/328 * Author: xinhua wang * Status: New * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- Add RAM disk/filesystem in SPI flash for tianocore -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Bug #327] (New) MBOX3, OperationRegion (OPRG, SystemMemory, ASLS, 0x2000) causes windows uefi tianocore BSOD ACPI_BIOS_ERROR
by coreboot＠fe80.eu 30 Dec '21

30 Dec '21

Issue #327 has been reported by xinhua wang. ---------------------------------------- Bug #327: MBOX3, OperationRegion (OPRG, SystemMemory, ASLS, 0x2000) causes windows uefi tianocore BSOD ACPI_BIOS_ERROR https://ticket.coreboot.org/issues/327 * Author: xinhua wang * Status: New * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- https://review.coreboot.org/c/coreboot/+/27711/7/src/drivers/intel/gma/acpi… this line .. OperationRegion (OPRG, SystemMemory, ASLS, 0x2000) the 0x2000 will cause BSOD ACPI_BIOS_ERROR when booting installer, os, etc When set to 0x1000 windows UEFI tianocore mode boots fine -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

[coreboot - Bug #326] (New) raminit fails after 58188 review.coreboot.org
by coreboot＠fe80.eu 30 Dec '21

30 Dec '21

Issue #326 has been reported by xinhua wang. ---------------------------------------- Bug #326: raminit fails after 58188 review.coreboot.org https://ticket.coreboot.org/issues/326 * Author: xinhua wang * Status: New * Priority: Normal * Assignee: * Category: * Target version: ---------------------------------------- For this addition.. https://review.coreboot.org/c/coreboot/+/58188 What is the cause of this? ft232h log with raminit debug enabled https://pastebin.com/kHC0bXLs Read MPR training failed: 1, 2, 0 raminit failed ---- If I remove the patches in here (top of message) it boots fine ft232h log with raminit debug enabled https://pastebin.com/e8xhet1V Any ideas? Thx If I need more debugging options please tell me how to enable it, thx -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: https://ticket.coreboot.org/my/account

1 0

How should we handle different endianness in cbtable?
by Igor Bagnucki 23 Dec '21

23 Dec '21

Dear coreboot community, as a part of coreboot port for Talos II POWER9 architecture, we are porting the cbmem tool. [1] This platform can switch between the big-endian and the little-endian. coreboot operates in big-endian but in theory it could also operate in little-endian, and the OS can also operate in both - little-endian and big-endian. This creates a situation where cbmem tries to read cbtable in different endianness than the cbtable was created. Therefore, cbmem needs to convert the endianness, and it needs to differentiate if the conversion is required or not. There are several ways we could differentiate if it is required to convert endianness or not. What would be the best approach to this problem? 1. Save endianness information in the cbtable header. For example, the signature on the big-endian coreboot could be “OIBL” instead “LBIO”. This solution would be very portable as the other tools looking for the cbtable but not expecting the big-endian format would simply not find the table instead of trying to read it and crashing. However, this change would need to be introduced in multiple places in coreboot as the signature is hardcoded in multiple where it was needed. 2. Add preprocessor checks to enable endianness conversion only on defined platforms. It would be easy to implement, but if the BIOS and the OS can have different endianness, then it could break for cbtable written in little-endian mode. 3. Recognize the correct endianness by checking some property of cbtable header. For example, header size property value could be checked if it reads as 0x18 or 0x18000000, but this solution requires very little changes but feels hacky and susceptible to changes in cbtable header format. 4. Add command-line option to cbmem so the user can choose what endianness should be used. I’m not sure about this solution, because it pushes the responsibility to recognize endianness to the user. [1] https://github.com/Dasharo/coreboot/pull/62 -- Igor Bagnucki Embedded Firmware Developer https://3mdeb.com | @3mdeb_com

2 1

[PATCH] CHROMIUM: i2c: Add device property for probing
by Paul Menzel 22 Dec '21

22 Dec '21

From: Furquan Shaikh <furquan(a)google.com> Dear Linux folks, Google Chromebooks are often built with devices sourced from different vendors. These need to be probed. To deal with this, the firmware – in this case coreboot – tags such optional devices accordingly – I think this is commit fbf2c79b (drivers/i2c/generic: Add config for marking device as probed) – and Chromium OS’ Linux kernel has the patch at hand applied to act accordingly. Right after the merge, Dmitry created a revert, which was actively discussed for two days but wasn’t applied. That means, millions of devices shipped with such a firmware and Linux kernel. To support these devices with upstream Linux kernel, is there an alternative to applying the patch to the Linux kernel, and to support the shipped devices? Kind regards, Paul [1]: https://review.coreboot.org/c/coreboot/+/16742/ [2]: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/… --------------- 8< -------------------------- >8 --------------- Add a new device property to indicate if an I2C device should be probed before being added. If this property is present and set then the I2C core layer will use i2c_new_probed_device() instead of i2c_new_device(). This can be used to provide devices in ACPI or DT that may not be present on the board. For example, multiple trackpad vendors can be supported on a single board with a unified firmware image this way by having their device address be probed before being added. This property is styled after the PCI Host Bridge probe property (bindings/pci/host-generic-pci.txt:linuxk,pci-probe-only) and is a linux specific directive to alter device probing. BUG=b:110013532 TEST=tested on soraka with 4.14 kernel: 1) add "linux,probed=1" device property to the touchscreen ACPI device on soraka and ensure that the device is probed before being added. tested on yorp with 4.14 kernel: 1) I2C devices without the "linux,probed=1" device property are still functional. Original-change-Id: I9cf689f7b75ef445c1f0e9f7ec143fa695eb398e Original-signed-off-by: Duncan Laurie <dlaurie(a)chromium.org> Original-reviewed-on: https://chromium-review.googlesource.com/388767 Original-reviewed-by: Benson Leung <bleung(a)chromium.org> Change-Id: I54015fe102f2834f6a094d9e650c166a0cc0583b Signed-off-by: Furquan Shaikh <furquan(a)google.com> Reviewed-on: https://chromium-review.googlesource.com/1100544 Commit-Ready: Furquan Shaikh <furquan(a)chromium.org> Tested-by: Furquan Shaikh <furquan(a)chromium.org> Reviewed-by: Justin TerAvest <teravest(a)chromium.org> Conflicts: drivers/i2c/i2c-core-of.c [rebase419(groeck): Context conflicts] Signed-off-by: Guenter Roeck <groeck(a)chromium.org> [rebase510(groeck): Context conflicts] Signed-off-by: Guenter Roeck <groeck(a)chromium.org> Change-Id: Id10adae00b381e62813fd6b8ce7c6c50f140c31b --- Documentation/devicetree/bindings/i2c/i2c.txt | 5 +++++ drivers/i2c/i2c-core-acpi.c | 12 +++++++++++- drivers/i2c/i2c-core-of.c | 10 +++++++++- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c.txt b/Documentation/devicetree/bindings/i2c/i2c.txt index b864916e087f..4921ee57f4c1 100644 --- a/Documentation/devicetree/bindings/i2c/i2c.txt +++ b/Documentation/devicetree/bindings/i2c/i2c.txt @@ -133,6 +133,11 @@ wants to support one of the below features, it should adapt these bindings. - wakeup-source device can be used as a wakeup source. +- linux,probed + If this property is present, then the I2C device will be + probed before being added using i2c_new_scanned_device, else + linux will instantiate the I2C device normally. + Binding may contain optional "interrupts" property, describing interrupts used by the device. I2C core will assign "irq" interrupt (or the very first interrupt if not using interrupt names) as primary interrupt for the slave. diff --git a/drivers/i2c/i2c-core-acpi.c b/drivers/i2c/i2c-core-acpi.c index 92c1cc07ed46..c970d99e4438 100644 --- a/drivers/i2c/i2c-core-acpi.c +++ b/drivers/i2c/i2c-core-acpi.c @@ -254,10 +254,20 @@ static void i2c_acpi_register_device(struct i2c_adapter *adapter, struct acpi_device *adev, struct i2c_board_info *info) { + struct i2c_client *client; + adev->power.flags.ignore_parent = true; acpi_device_set_enumerated(adev); - if (IS_ERR(i2c_new_client_device(adapter, info))) + if (!acpi_dev_get_property(adev, "linux,probed", ACPI_TYPE_ANY, NULL)) { + unsigned short addrs[] = { info->addr, I2C_CLIENT_END }; + + client = i2c_new_scanned_device(adapter, info, addrs, NULL); + } else { + client = i2c_new_client_device(adapter, info); + } + + if (IS_ERR(client)) adev->power.flags.ignore_parent = false; } diff --git a/drivers/i2c/i2c-core-of.c b/drivers/i2c/i2c-core-of.c index 3ed74aa4b44b..fd375ce38a9e 100644 --- a/drivers/i2c/i2c-core-of.c +++ b/drivers/i2c/i2c-core-of.c @@ -75,7 +75,15 @@ static struct i2c_client *of_i2c_register_device(struct i2c_adapter *adap, if (ret) return ERR_PTR(ret); - client = i2c_new_client_device(adap, &info); + /* Allow device property to enable probing before init */ + if (of_get_property(node, "linux,probed", NULL)) { + unsigned short addrs[] = { info.addr, I2C_CLIENT_END }; + + client = i2c_new_scanned_device(adap, &info, addrs, NULL); + } else { + client = i2c_new_client_device(adap, &info); + } + if (IS_ERR(client)) dev_err(&adap->dev, "of_i2c: Failure registering %pOF\n", node); -- 2.34.1

3 5

Sublime Text Syntax Highlighting
by Raul Rangel 18 Dec '21

18 Dec '21

Hey all, If you use Sublime Text, I wanted to point out the [Coreboot Syntax](https://packagecontrol.io/packages/Coreboot%20syntax) package. It includes Device Tree support and I recently added ASL support. Let me know if you encounter any strange highlighting issues. Raul

2 1

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot