coreboot September 2015

coreboot@coreboot.org

36 participants
50 discussions

Re: [coreboot] [help]build cbfstool fail with cygwin64
by Patrick Georgi 11 Sep '15

11 Sep '15

2015-09-09 11:42 GMT+02:00 Kurt Qiao <kurtqqh(a)gmail.com>: > 5.make > then fail as below > ---- > <stdout>: In function 'yy_init_buffer': > <stdout>:1395:9: error: implicit declaration of function 'fileno' > [-Werror=implicit-function-declaration] > --- > > i follow link [2] to modify cbfstool makefile, add _D_GNU_SOURCE for > TOOLCPPFLAGS, CPPFLAGS That doesn't fix the missing fileno declaration, which is the root cause. C standard library providers for Windows seem to be undecided what to do on this function (according to a quick internet search for cygwin and fileno). Sadly I haven't found a simple solution and don't have a system around for testing. Patrick -- Google Germany GmbH, ABC-Str. 19, 20354 Hamburg Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft: Hamburg Geschäftsführer: Graham Law, Christine Elizabeth Flores

1 0

Re: [coreboot] STACK_SIZE pcengines apu1
by Julius Werner 11 Sep '15

11 Sep '15

I'd bet it's just a single large allocation somewhere. You can try adding CFLAGS_ramstage += -Wstack-usage=1024 somewhere in coreboot/Makefile.inc and then clean+rebuild your code while passing '-k' to make. You'll get a bunch of compiler warnings, and one of them is likely to be the culprit.

1 0

Re: [coreboot] STACK_SIZE pcengines apu1
by Maxime de Roucy 11 Sep '15

11 Sep '15

Le jeudi 10 septembre 2015 à 09:02 -0500, Aaron Durbin a écrit : > That's quite the stack usage. It'd be interesting to know what's > using all that stack. Could you apply this patch and run w/ it? It'd > help narrow down at what point in the boot where the stack gets used > up. You will find the spew log of the modified coreboot you asked. (it's a reboot, not a boot… I don't know if that's change something). -- Regards Maxime

2 1

Re: [coreboot] coreinfo "General Protection Fault Exception"
by Maxime de Roucy 10 Sep '15

10 Sep '15

Le jeudi 10 septembre 2015 à 15:35 +0000, Marc Jones a écrit : > It looks like coreinfo is the only payload, so there is nothing to > exit back to. What were you expecting to happen? > > You can try using seabios with multiple payloads or work with bayou > as a multiple payload loader. No, coreinfo isn't the only payload. SeaBIOS is the main payload, I also have memtest and ipxe (once I also have nvramcui). I didn't expect coreinfo to launch to the next payload when it stop. I expect it to reboot the computer as nvramcui do. max@max-laptop % ./cbfstool coreboot.rom print coreboot.rom: 2048 kB, bootblocksize 1576, romsize 2097152, offset 0x0 alignment: 64 bytes, architecture: x86 Name Offset Type Size … genroms/ipxe.rom 0x6a880 raw 56832 img/coreinfo 0x786c0 payload 65500 img/memtest 0x88700 payload 147240 … -- Regards Maxime

1 0

Re: [coreboot] STACK_SIZE pcengines apu1
by Sheng-Liang Song 10 Sep '15

10 Sep '15

It is better to review the pcengines apu1 boot code--pay attention on any function that uses >= 64B stack storage (function arguments and local variables). Try reduce the stack size of such functions instead of increasing the STACK_SIZE. On Thu, Sep 10, 2015 at 7:02 AM, Aaron Durbin <adurbin(a)google.com> wrote: > On Sun, Sep 6, 2015 at 9:10 AM, Maxime de Roucy > <maxime.deroucy(a)gmail.com> wrote: > > Hello, > > > > I am building a coreboot rom for my pcengines apu1. > > A bug is logged during the boot process : > > > http://review.coreboot.org/gitweb?p=board-status.git;a=blob;f=pcengines/apu… > > > > In order to solve it I applied this changed : > > > > diff --git a/src/Kconfig b/src/Kconfig > > index 9c01687..c8b8ad2 100644 > > --- a/src/Kconfig > > +++ b/src/Kconfig > > @@ -427,7 +427,7 @@ config HEAP_SIZE > > config STACK_SIZE > > hex > > default 0x0 if (ARCH_RAMSTAGE_ARM || ARCH_RAMSTAGE_MIPS || > ARCH_RAMSTAGE_RISCV) > > - default 0x1000 > > + default 0x2000 > > > > config MAX_CPUS > > int > > > > I don't see the bug line anymore, instead I see : > > > > CPU0: stack: 00148000 - 0014a000, lowest used address 00148d34, > stack used: 4812 bytes > > > > I now the patch is not good since it change the default stack size for > > all the boards. I didn't found the right place the change the stack > > size only for pcengines apu1 board. > > But maybe those informations can help developers to improve coreboot. > > That's quite the stack usage. It'd be interesting to know what's > using all that stack. Could you apply this patch and run w/ it? It'd > help narrow down at what point in the boot where the stack gets used > up. Also, that you used 4812 bytes just means you overwrote the other > CPU's stack at some point when STACK_SIZE == 4KiB. > > > diff --git a/src/lib/hardwaremain.c b/src/lib/hardwaremain.c > index b3c0c35..8a241b2 100644 > --- a/src/lib/hardwaremain.c > +++ b/src/lib/hardwaremain.c > @@ -378,6 +378,8 @@ static void bs_walk_state_machine(void) > bs_report_time(state); > > state->complete = 1; > + > + checkstack(_estack, 0); > } > } > > > > -- > > Regards > > Maxime de Roucy > > -- > > coreboot mailing list: coreboot(a)coreboot.org > > http://www.coreboot.org/mailman/listinfo/coreboot > > -- > coreboot mailing list: coreboot(a)coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot > -- Sheng-Liang Song | Software Engineer | ssl(a)google.com | 650-537-5017

1 0

STACK_SIZE pcengines apu1
by Maxime de Roucy 10 Sep '15

10 Sep '15

Hello, I am building a coreboot rom for my pcengines apu1. A bug is logged during the boot process : http://review.coreboot.org/gitweb?p=board-status.git;a=blob;f=pcengines/apu… In order to solve it I applied this changed : diff --git a/src/Kconfig b/src/Kconfig index 9c01687..c8b8ad2 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -427,7 +427,7 @@ config HEAP_SIZE config STACK_SIZE hex default 0x0 if (ARCH_RAMSTAGE_ARM || ARCH_RAMSTAGE_MIPS || ARCH_RAMSTAGE_RISCV) - default 0x1000 + default 0x2000 config MAX_CPUS int I don't see the bug line anymore, instead I see : CPU0: stack: 00148000 - 0014a000, lowest used address 00148d34, stack used: 4812 bytes I now the patch is not good since it change the default stack size for all the boards. I didn't found the right place the change the stack size only for pcengines apu1 board. But maybe those informations can help developers to improve coreboot. -- Regards Maxime de Roucy

2 1

Re: [coreboot] [help]build cbfstool fail with cygwin64
by Bao, Zheng 10 Sep '15

10 Sep '15

You can remove the -Werror In util/cbfstool/Makefile.inc Try again. Zheng. > -----Original Message----- > From: coreboot [mailto:coreboot-bounces@coreboot.org] On Behalf Of Kurt Qiao > Sent: Wednesday, September 09, 2015 5:43 PM > To: coreboot(a)coreboot.org > Subject: [coreboot] [help]build cbfstool fail with cygwin64 > > does anyone try cygwin64 to build coreboot in windows7 64bit? > i got fail when build cbfstool with cygwin64. > my steps as below: > > 1. cygwin64 install utility "patch", "flex", 'wget' etc. > > 2. git pull latest coreboot from github > build crossgcc > ./buildgcc -j 4 > > 3. build iasl > download src from link [1] > make > cp acpica-unix-20150818/generate/unix/bin/iasl /usr/local/bin > > 4. make menuconfig > choose "emulation/qemu-q35" in my case > > 5.make > then fail as below > ---- > <stdout>: In function 'yy_init_buffer': > <stdout>:1395:9: error: implicit declaration of function 'fileno' > [-Werror=implicit-function-declaration] > cc1: all warnings being treated as errors > util/cbfstool/Makefile.inc:59: recipe for target > 'build/util/cbfstool/fmd_scanner.o' failed > make: *** [build/util/cbfstool/fmd_scanner.o] Error 1 > --- > > i follow link [2] to modify cbfstool makefile, add _D_GNU_SOURCE for > TOOLCPPFLAGS, CPPFLAGS and fail as below log. > --- > Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 432 Optimizations > HOSTCC cbfstool/fmaptool.o > HOSTCC cbfstool/cbfs_sections.o > HOSTCC cbfstool/fmap_from_fmd.o > HOSTCC cbfstool/fmd.o > HOSTCC cbfstool/fmd_parser.o > HOSTCC cbfstool/fmd_scanner.o > HOSTCC cbfstool/fmap.o > HOSTCC cbfstool/kv_pair.o > HOSTCC cbfstool/valstr.o > HOSTCC cbfstool/fmaptool (link) > build/util/cbfstool/fmd.o:fmd.c:(.text+0xa23): undefined reference to > `yylex_destroy' > build/util/cbfstool/fmd.o:fmd.c:(.text+0xa23): relocation truncated to > fit: R_X86_64_PC32 against undefined symbol `yylex_destroy' > build/util/cbfstool/fmd.o:fmd.c:(.rdata$.refptr.yyin[.refptr.yyin]+0x0): > undefined reference to `yyin' > build/util/cbfstool/fmd_parser.o:fmd_parser.c:(.text+0x386): undefined > reference to `yylex' > build/util/cbfstool/fmd_parser.o:fmd_parser.c:(.text+0x386): > relocation truncated to fit: R_X86_64_PC32 against undefined symbol `yylex' > collect2: error: ld returned 1 exit status > util/cbfstool/Makefile.inc:83: recipe for target > 'build/util/cbfstool/fmaptool' failed > make: *** [build/util/cbfstool/fmaptool] Error 1 > --- > > [1]:https://acpica.org/sites/acpica/files/acpica-unix-20150818.tar.gz > [2]:http://review.coreboot.org/#/c/10027/1 > > -- > coreboot mailing list: coreboot(a)coreboot.org > http://www.coreboot.org/mailman/listinfo/coreboot

1 0

Re: [coreboot] Change in coreboot[master]: coreboot_table: don't add CMOS checksum twice.
by Nico Huber 09 Sep '15

09 Sep '15

Am 16.04.2015 15:12, schrieb gerrit code review: > From Nico Huber <nico.h(a)gmx.de>: > > Nico Huber has posted comments on this change. > > Change subject: coreboot_table: don't add CMOS checksum twice. > ...................................................................... > > > Patch Set 3: > > Ahh, took me a day to find this commit and what is going wrong. > > You were right, that the checksum appeared twice in a row. But that's > only true, if you don't read the table from the beginning: The > checksum from the cmos_layout is nested in another tag. That makes a > difference because libpayload parses the table, looks for the > checksum, but doesn't understand nested tags. > > I hadn't the time to check whether this problem persists upstream, but > it looks like it does. This still persists. To be clear: This change was meant to be cosmetic but has real impact. Upstream, libpayload is unable to read nvram variables since this has been merged (January 2014). The commit still seems to be a good idea. But If nobody plans to adapt libpayload, shall we revert it? Nico -- To view, visit http://review.coreboot.org/4829 To unsubscribe, visit http://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d12f35fd8ff12eee9a17365bbfab38845c09574 Gerrit-PatchSet: 3 Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: Alexandru Gagniuc <mr.nuke.me(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No -- M. Sc. Nico Huber Senior Berater SINA-Softwareentwicklung Netzwerk- & Client-Sicherheit / Network & Client Security Division Öffentliche Auftraggeber / Public Authorities secunet Security Networks AG Tel.: +49-201-5454-3635, Fax: +49-201-5454-1325 E-Mail: nico.huber(a)secunet.com Mergenthalerallee 77, 65760 Eschborn, Deutschland www.secunet.com ______________________________________________________________________ Sitz: Kronprinzenstraße 30, 45128 Essen, Deutschland Amtsgericht Essen HRB 13615 Vorstand: Dr. Rainer Baumgart (Vors.), Thomas Pleines Aufsichtsratsvorsitzender: Dr. Peter Zattler ______________________________________________________________________

1 0

[help]build cbfstool fail with cygwin64
by Kurt Qiao 09 Sep '15

09 Sep '15

does anyone try cygwin64 to build coreboot in windows7 64bit? i got fail when build cbfstool with cygwin64. my steps as below: 1. cygwin64 install utility "patch", "flex", 'wget' etc. 2. git pull latest coreboot from github build crossgcc ./buildgcc -j 4 3. build iasl download src from link [1] make cp acpica-unix-20150818/generate/unix/bin/iasl /usr/local/bin 4. make menuconfig choose "emulation/qemu-q35" in my case 5.make then fail as below ---- <stdout>: In function 'yy_init_buffer': <stdout>:1395:9: error: implicit declaration of function 'fileno' [-Werror=implicit-function-declaration] cc1: all warnings being treated as errors util/cbfstool/Makefile.inc:59: recipe for target 'build/util/cbfstool/fmd_scanner.o' failed make: *** [build/util/cbfstool/fmd_scanner.o] Error 1 --- i follow link [2] to modify cbfstool makefile, add _D_GNU_SOURCE for TOOLCPPFLAGS, CPPFLAGS and fail as below log. --- Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 432 Optimizations HOSTCC cbfstool/fmaptool.o HOSTCC cbfstool/cbfs_sections.o HOSTCC cbfstool/fmap_from_fmd.o HOSTCC cbfstool/fmd.o HOSTCC cbfstool/fmd_parser.o HOSTCC cbfstool/fmd_scanner.o HOSTCC cbfstool/fmap.o HOSTCC cbfstool/kv_pair.o HOSTCC cbfstool/valstr.o HOSTCC cbfstool/fmaptool (link) build/util/cbfstool/fmd.o:fmd.c:(.text+0xa23): undefined reference to `yylex_destroy' build/util/cbfstool/fmd.o:fmd.c:(.text+0xa23): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `yylex_destroy' build/util/cbfstool/fmd.o:fmd.c:(.rdata$.refptr.yyin[.refptr.yyin]+0x0): undefined reference to `yyin' build/util/cbfstool/fmd_parser.o:fmd_parser.c:(.text+0x386): undefined reference to `yylex' build/util/cbfstool/fmd_parser.o:fmd_parser.c:(.text+0x386): relocation truncated to fit: R_X86_64_PC32 against undefined symbol `yylex' collect2: error: ld returned 1 exit status util/cbfstool/Makefile.inc:83: recipe for target 'build/util/cbfstool/fmaptool' failed make: *** [build/util/cbfstool/fmaptool] Error 1 --- [1]:https://acpica.org/sites/acpica/files/acpica-unix-20150818.tar.gz [2]:http://review.coreboot.org/#/c/10027/1

1 0

New Defects reported by Coverity Scan for coreboot
by scan-admin＠coverity.com 09 Sep '15

09 Sep '15

Hi, Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan. 47 new defect(s) introduced to coreboot found with Coverity Scan. 353 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 47 defect(s) ** CID 1323498: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t114/nvbctlib_t114.c: 194 in t114_get_sdram_param() ________________________________________________________________________________________________________ *** CID 1323498: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t114/nvbctlib_t114.c: 194 in t114_get_sdram_param() 188 u_int32_t *value) 189 { 190 nvboot_sdram_params *params; 191 nvboot_config_table *bct = NULL; 192 193 bct = (nvboot_config_table *)(context->bct); >>> CID 1323498: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 194 assert(context != NULL); 195 assert(bct != NULL); 196 params = &(bct->sdram_params[index]); 197 198 switch (token) { 199 CASE_GET_SDRAM_PARAM(memory_type); ** CID 1323497: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t114/nvbctlib_t114.c: 1091 in t114_init_bad_block_table() ________________________________________________________________________________________________________ *** CID 1323497: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t114/nvbctlib_t114.c: 1091 in t114_init_bad_block_table() 1085 u_int32_t bytes_per_entry; 1086 nvboot_badblock_table *table; 1087 nvboot_config_table *bct; 1088 1089 bct = (nvboot_config_table *)(context->bct); 1090 >>> CID 1323497: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1091 assert(context != NULL); 1092 assert(bct != NULL); 1093 1094 table = &bct->badblock_table; 1095 1096 bytes_per_entry = ICEIL(context->partition_size, ** CID 1323496: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t114/nvbctlib_t114.c: 123 in t114_set_dev_param() ________________________________________________________________________________________________________ *** CID 1323496: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t114/nvbctlib_t114.c: 123 in t114_set_dev_param() 117 parse_token token, 118 u_int32_t value) 119 { 120 nvboot_config_table *bct = NULL; 121 122 bct = (nvboot_config_table *)(context->bct); >>> CID 1323496: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 123 assert(context != NULL); 124 assert(bct != NULL); 125 126 bct->num_param_sets = NV_MAX(bct->num_param_sets, index + 1); 127 128 switch (token) { ** CID 1323495: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t114/nvbctlib_t114.c: 525 in t114_set_sdram_param() ________________________________________________________________________________________________________ *** CID 1323495: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t114/nvbctlib_t114.c: 525 in t114_set_sdram_param() 519 u_int32_t value) 520 { 521 nvboot_sdram_params *params; 522 nvboot_config_table *bct = NULL; 523 524 bct = (nvboot_config_table *)(context->bct); >>> CID 1323495: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 525 assert(context != NULL); 526 assert(bct != NULL); 527 params = &(bct->sdram_params[index]); 528 /* Update the number of SDRAM parameter sets. */ 529 bct->num_sdram_sets = NV_MAX(bct->num_sdram_sets, index + 1); 530 ** CID 1323494: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 174 in t30_get_dev_param() ________________________________________________________________________________________________________ *** CID 1323494: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 174 in t30_get_dev_param() 168 parse_token token, 169 u_int32_t *value) 170 { 171 nvboot_config_table *bct = NULL; 172 173 bct = (nvboot_config_table *)(context->bct); >>> CID 1323494: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 174 assert(context != NULL); 175 assert(bct != NULL); 176 177 switch (token) { 178 CASE_GET_DEV_PARAM(nand, clock_divider); 179 CASE_GET_DEV_PARAM(nand, block_size_log2); ** CID 1323493: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 224 in t30_get_sdram_param() ________________________________________________________________________________________________________ *** CID 1323493: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 224 in t30_get_sdram_param() 218 u_int32_t *value) 219 { 220 nvboot_sdram_params *params; 221 nvboot_config_table *bct = NULL; 222 223 bct = (nvboot_config_table *)(context->bct); >>> CID 1323493: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 224 assert(context != NULL); 225 assert(bct != NULL); 226 params = &(bct->sdram_params[index]); 227 228 switch (token) { 229 CASE_GET_SDRAM_PARAM(memory_type); ** CID 1323492: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 879 in t30_init_bad_block_table() ________________________________________________________________________________________________________ *** CID 1323492: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 879 in t30_init_bad_block_table() 873 u_int32_t bytes_per_entry; 874 nvboot_badblock_table *table; 875 nvboot_config_table *bct; 876 877 bct = (nvboot_config_table *)(context->bct); 878 >>> CID 1323492: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 879 assert(context != NULL); 880 assert(bct != NULL); 881 882 table = &bct->badblock_table; 883 884 bytes_per_entry = ICEIL(context->partition_size, ** CID 1323491: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 123 in t30_set_dev_param() ________________________________________________________________________________________________________ *** CID 1323491: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 123 in t30_set_dev_param() 117 parse_token token, 118 u_int32_t value) 119 { 120 nvboot_config_table *bct = NULL; 121 122 bct = (nvboot_config_table *)(context->bct); >>> CID 1323491: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 123 assert(context != NULL); 124 assert(bct != NULL); 125 126 bct->num_param_sets = NV_MAX(bct->num_param_sets, index + 1); 127 128 switch (token) { ** CID 1323490: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 438 in t30_set_sdram_param() ________________________________________________________________________________________________________ *** CID 1323490: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t30/nvbctlib_t30.c: 438 in t30_set_sdram_param() 432 u_int32_t value) 433 { 434 nvboot_sdram_params *params; 435 nvboot_config_table *bct = NULL; 436 437 bct = (nvboot_config_table *)(context->bct); >>> CID 1323490: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 438 assert(context != NULL); 439 assert(bct != NULL); 440 params = &(bct->sdram_params[index]); 441 /* Update the number of SDRAM parameter sets. */ 442 bct->num_sdram_sets = NV_MAX(bct->num_sdram_sets, index + 1); 443 ** CID 1323489: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 163 in t20_get_dev_param() ________________________________________________________________________________________________________ *** CID 1323489: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 163 in t20_get_dev_param() 157 parse_token token, 158 u_int32_t *value) 159 { 160 nvboot_config_table *bct = NULL; 161 162 bct = (nvboot_config_table *)(context->bct); >>> CID 1323489: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 163 assert(context != NULL); 164 assert(bct != NULL); 165 166 switch (token) { 167 CASE_GET_DEV_PARAM(nand, clock_divider); 168 CASE_GET_DEV_PARAM(nand, nand_timing); ** CID 1323488: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 326 in t20_get_sdram_param() ________________________________________________________________________________________________________ *** CID 1323488: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 326 in t20_get_sdram_param() 320 u_int32_t *value) 321 { 322 nvboot_sdram_params *params; 323 nvboot_config_table *bct = NULL; 324 325 bct = (nvboot_config_table *)(context->bct); >>> CID 1323488: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 326 assert(context != NULL); 327 assert(bct != NULL); 328 params = &(bct->sdram_params[index]); 329 330 switch (token) { 331 CASE_GET_SDRAM_PARAM(memory_type); ** CID 1323487: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 672 in t20_init_bad_block_table() ________________________________________________________________________________________________________ *** CID 1323487: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 672 in t20_init_bad_block_table() 666 u_int32_t bytes_per_entry; 667 nvboot_badblock_table *table; 668 nvboot_config_table *bct; 669 670 bct = (nvboot_config_table *)(context->bct); 671 >>> CID 1323487: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 672 assert(context != NULL); 673 assert(bct != NULL); 674 675 table = &bct->badblock_table; 676 677 bytes_per_entry = ICEIL(context->partition_size, ** CID 1323486: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 123 in t20_set_dev_param() ________________________________________________________________________________________________________ *** CID 1323486: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 123 in t20_set_dev_param() 117 parse_token token, 118 u_int32_t value) 119 { 120 nvboot_config_table *bct = NULL; 121 122 bct = (nvboot_config_table *)(context->bct); >>> CID 1323486: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 123 assert(context != NULL); 124 assert(bct != NULL); 125 126 bct->num_param_sets = NV_MAX(bct->num_param_sets, index + 1); 127 128 switch (token) { ** CID 1323485: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 202 in t20_set_sdram_param() ________________________________________________________________________________________________________ *** CID 1323485: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t20/nvbctlib_t20.c: 202 in t20_set_sdram_param() 196 u_int32_t value) 197 { 198 nvboot_sdram_params *params; 199 nvboot_config_table *bct = NULL; 200 201 bct = (nvboot_config_table *)(context->bct); >>> CID 1323485: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 202 assert(context != NULL); 203 assert(bct != NULL); 204 params = &(bct->sdram_params[index]); 205 /* Update the number of SDRAM parameter sets. */ 206 bct->num_sdram_sets = NV_MAX(bct->num_sdram_sets, index + 1); 207 ** CID 1323484: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 164 in t124_get_dev_param() ________________________________________________________________________________________________________ *** CID 1323484: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 164 in t124_get_dev_param() 158 parse_token token, 159 u_int32_t *value) 160 { 161 nvboot_config_table *bct = NULL; 162 163 bct = (nvboot_config_table *)(context->bct); >>> CID 1323484: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 164 assert(context != NULL); 165 assert(bct != NULL); 166 167 switch (token) { 168 CASE_GET_DEV_PARAM(sdmmc, clock_divider); 169 CASE_GET_DEV_PARAM(sdmmc, data_width); ** CID 1323483: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 199 in t124_get_sdram_param() ________________________________________________________________________________________________________ *** CID 1323483: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 199 in t124_get_sdram_param() 193 u_int32_t *value) 194 { 195 nvboot_sdram_params *params; 196 nvboot_config_table *bct = NULL; 197 198 bct = (nvboot_config_table *)(context->bct); >>> CID 1323483: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 199 assert(context != NULL); 200 assert(bct != NULL); 201 params = &(bct->sdram_params[index]); 202 203 switch (token) { 204 CASE_GET_SDRAM_PARAM(memory_type); ** CID 1323482: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 1104 in t124_init_bad_block_table() ________________________________________________________________________________________________________ *** CID 1323482: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 1104 in t124_init_bad_block_table() 1098 u_int32_t bytes_per_entry; 1099 nvboot_badblock_table *table; 1100 nvboot_config_table *bct; 1101 1102 bct = (nvboot_config_table *)(context->bct); 1103 >>> CID 1323482: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 1104 assert(context != NULL); 1105 assert(bct != NULL); 1106 1107 table = &bct->badblock_table; 1108 1109 bytes_per_entry = ICEIL(context->partition_size, ** CID 1323481: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 128 in t124_set_dev_param() ________________________________________________________________________________________________________ *** CID 1323481: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 128 in t124_set_dev_param() 122 parse_token token, 123 u_int32_t value) 124 { 125 nvboot_config_table *bct = NULL; 126 127 bct = (nvboot_config_table *)(context->bct); >>> CID 1323481: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 128 assert(context != NULL); 129 assert(bct != NULL); 130 131 bct->num_param_sets = NV_MAX(bct->num_param_sets, index + 1); 132 133 switch (token) { ** CID 1323480: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 529 in t124_set_sdram_param() ________________________________________________________________________________________________________ *** CID 1323480: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t124/nvbctlib_t124.c: 529 in t124_set_sdram_param() 523 u_int32_t value) 524 { 525 nvboot_sdram_params *params; 526 nvboot_config_table *bct = NULL; 527 528 bct = (nvboot_config_table *)(context->bct); >>> CID 1323480: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 529 assert(context != NULL); 530 assert(bct != NULL); 531 params = &(bct->sdram_params[index]); 532 /* Update the number of SDRAM parameter sets. */ 533 bct->num_sdram_sets = NV_MAX(bct->num_sdram_sets, index + 1); 534 ** CID 1323479: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t210/nvbctlib_t210.c: 164 in t210_get_dev_param() ________________________________________________________________________________________________________ *** CID 1323479: Null pointer dereferences (REVERSE_INULL) /util/nvidia/cbootimage/src/t210/nvbctlib_t210.c: 164 in t210_get_dev_param() 158 parse_token token, 159 u_int32_t *value) 160 { 161 nvboot_config_table *bct = NULL; 162 163 bct = (nvboot_config_table *)(context->bct); >>> CID 1323479: Null pointer dereferences (REVERSE_INULL) >>> Null-checking "context" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 164 assert(context != NULL); 165 assert(bct != NULL); 166 167 switch (token) { 168 CASE_GET_DEV_PARAM(sdmmc, clock_divider); 169 CASE_GET_DEV_PARAM(sdmmc, data_width); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/coreboot?tab=overview To manage Coverity Scan email notifications for "coreboot(a)coreboot.org", click https://scan.coverity.com/subscriptions/edit?email=coreboot%40coreboot.org&…

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot September 2015