coreboot November 2012

coreboot@coreboot.org

35 participants
895 discussions

New patch to review for coreboot: 12738f7 Only compile in devices that are relevant to the platform
by Ronald G. Minnich 29 Nov '12

29 Nov '12

Ronald G. Minnich (rminnich(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1943 -gerrit commit 12738f77368844779945333900f35b646fb2dc89 Author: Ronald G. Minnich <rminnich(a)gmail.com> Date: Thu Nov 29 10:11:51 2012 -0800 Only compile in devices that are relevant to the platform At this point, in coreboot, only x86 platforms have any kind of PCI. WHile this many change in the future, for now, it's the reality. Therefore, we don't compile in hardware that has no meaning on non-x86 platforms. Change-Id: If3f0308f91b50b1304969ec1bbf5f8d2063c10f9 Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> --- src/devices/Makefile.inc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/devices/Makefile.inc b/src/devices/Makefile.inc index 9d4b391..c0254ee 100644 --- a/src/devices/Makefile.inc +++ b/src/devices/Makefile.inc @@ -2,14 +2,14 @@ ramstage-y += device.c ramstage-y += root_device.c ramstage-y += cpu_device.c ramstage-y += device_util.c -ramstage-y += pci_device.c +ramstage-$(CONFIG_ARCH_X86) += pci_device.c ramstage-$(CONFIG_HYPERTRANSPORT_PLUGIN_SUPPORT) += hypertransport.c ramstage-$(CONFIG_PCIX_PLUGIN_SUPPORT) += pcix_device.c -ramstage-y += pciexp_device.c +ramstage-$(CONFIG_ARCH_X86) += pciexp_device.c ramstage-$(CONFIG_AGP_PLUGIN_SUPPORT) += agp_device.c ramstage-$(CONFIG_CARDBUS_PLUGIN_SUPPORT) += cardbus_device.c -ramstage-y += pnp_device.c -ramstage-y += pci_ops.c +ramstage-$(CONFIG_ARCH_X86) += pnp_device.c +ramstage-$(CONFIG_ARCH_X86) += pci_ops.c ramstage-y += smbus_ops.c romstage-y+= device_romstage.c

1 0

Patch merged into coreboot/master: 6d1fcd5 crossgcc: Only build iasl in acpica.
by gerrit＠coreboot.org 29 Nov '12

29 Nov '12

the following patch was just integrated into master: commit 6d1fcd5e0bccea7f813706fce84c815c2782a356 Author: Zheng Bao <fishbaozi(a)gmail.com> Date: Wed Nov 28 16:13:40 2012 +0800 crossgcc: Only build iasl in acpica. Other acpica's modules are not needed. Change-Id: I16846caa922aded8db7c1d9e64c007fb2772ff98 Signed-off-by: Zheng Bao <zheng.bao(a)amd.com> Signed-off-by: zbao <fishbaozi(a)gmail.com> Reviewed-on: http://review.coreboot.org/1935 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)users.sourceforge.net> See http://review.coreboot.org/1935 for details. -gerrit

1 0

New patch to review for coreboot: 876ec78 libpayload: Remove unused FLAG_USED from memory allocator
by Patrick Georgi 29 Nov '12

29 Nov '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1942 -gerrit commit 876ec78af9f6c9c5251774fbe19cf3ef8769699d Author: Nico Huber <nico.huber(a)secunet.com> Date: Mon Oct 8 15:03:35 2012 +0200 libpayload: Remove unused FLAG_USED from memory allocator The FLAG_USED bit in the memory allocator's header type was never read. This removes it to save one bit for the region size so we can have heaps of up to 32MiB. Change-Id: Ibd78e67d79e872d6df426516667c795fd52326d5 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- payloads/libpayload/libc/malloc.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/payloads/libpayload/libc/malloc.c b/payloads/libpayload/libc/malloc.c index 82bae3c..7756a3b 100644 --- a/payloads/libpayload/libc/malloc.c +++ b/payloads/libpayload/libc/malloc.c @@ -37,6 +37,9 @@ * We're also susceptible to the usual buffer overrun poisoning, though the * risk is within acceptable ranges for this implementation (don't overrun * your buffers, kids!). + * + * The header format (hdrtype_t) supports heaps of up to 32MiB (given that int + * is 32 bits long). */ #define IN_MALLOC_C @@ -51,14 +54,15 @@ typedef unsigned int hdrtype_t; #define MAGIC (0x2a << 26) #define FLAG_FREE (1 << 25) -#define FLAG_USED (1 << 24) +#define SIZE_BITS 25 +#define MAX_SIZE ((1 << SIZE_BITS) - 1) -#define SIZE(_h) ((_h) & 0xFFFFFF) +#define SIZE(_h) ((_h) & MAX_SIZE) -#define _HEADER(_s, _f) ((hdrtype_t) (MAGIC | (_f) | ((_s) & 0xFFFFFF))) +#define _HEADER(_s, _f) ((hdrtype_t) (MAGIC | (_f) | ((_s) & MAX_SIZE))) #define FREE_BLOCK(_s) _HEADER(_s, FLAG_FREE) -#define USED_BLOCK(_s) _HEADER(_s, FLAG_USED) +#define USED_BLOCK(_s) _HEADER(_s, 0) #define HDRSIZE (sizeof(hdrtype_t)) @@ -91,7 +95,7 @@ static void *alloc(int len) /* Align the size. */ len = (len + 3) & ~3; - if (!len || len > 0xffffff) + if (!len || len > MAX_SIZE) return (void *)NULL; /* Make sure the region is setup correctly. */

1 0

New patch to review for coreboot: d32cde9 libpayload: Fix lookup by label in CMOS layouts
by Patrick Georgi 29 Nov '12

29 Nov '12

Patrick Georgi (patrick(a)georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1941 -gerrit commit d32cde99c4b52c57bb7afa8fa16d5820212bf2b4 Author: Nico Huber <nico.huber(a)secunet.com> Date: Fri Nov 9 18:12:21 2012 +0100 libpayload: Fix lookup by label in CMOS layouts The condition to compare the labels was twisted. Change-Id: I34a665aa87e2ff0480eda0f249bbbea8a8fe68d8 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- payloads/libpayload/drivers/options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payloads/libpayload/drivers/options.c b/payloads/libpayload/drivers/options.c index d15d81b..d497c0a 100644 --- a/payloads/libpayload/drivers/options.c +++ b/payloads/libpayload/drivers/options.c @@ -243,7 +243,7 @@ static struct cb_cmos_enums *lookup_cmos_enum_core(struct cb_cmos_option_table * cmos_enum; cmos_enum = next_cmos_enum_of_id(cmos_enum, config_id)) { if (((value == NULL) || (cmos_enum->value == *value)) && - ((text == NULL) || (memcmp((const char*)cmos_enum->text, text, len)))) { + ((text == NULL) || (memcmp((const char*)cmos_enum->text, text, len) == 0))) { return cmos_enum; } }

1 0

Patch merged into coreboot/master: 9824328 Drop empty mainboard.c
by gerrit＠coreboot.org 29 Nov '12

29 Nov '12

the following patch was just integrated into master: commit 98243281e70192612e275133644f8df173badef5 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Aug 23 19:16:01 2012 +0300 Drop empty mainboard.c Change-Id: Idcf9349d96297b8cb0ea1e68769e02659ac16ab8 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/1933 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/1933 for details. -gerrit

1 0

Patch merged into coreboot/master: 897aeeb Drop empty mainboard_ops
by gerrit＠coreboot.org 29 Nov '12

29 Nov '12

the following patch was just integrated into master: commit 897aeeba4bd7ddb483e550d1d6e820186dfa4bcf Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Aug 23 12:20:35 2012 +0300 Drop empty mainboard_ops Change-Id: I24866142eebcb8fdbc7e21f5b2f364a8d1b264b3 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/1932 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/1932 for details. -gerrit

1 0

Patch merged into coreboot/master: e773c92 Make mainboard_ops and mainboard.c file optional
by gerrit＠coreboot.org 29 Nov '12

29 Nov '12

the following patch was just integrated into master: commit e773c92ef44be12108c61ce342b0d48ad6c6ddd6 Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Date: Thu Nov 15 07:05:43 2012 +0200 Make mainboard_ops and mainboard.c file optional This provides weak empty declaration for mainboard_ops. The struct chip_operations is not defined for __PRE_RAM__ so the declaration is also moved upwards in the output. Change-Id: I101f0b8b9f0a55fb51a7c6475d53cc588c84026d Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: http://review.coreboot.org/1931 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/1931 for details. -gerrit

1 0

Patch merged into coreboot/master: 95efb56 pirq_route_irqs is private
by gerrit＠coreboot.org 29 Nov '12

29 Nov '12

the following patch was just integrated into master: commit 95efb565b6581c98df9064aeaa6b63dc3dfad2f6 Author: Patrick Georgi <patrick(a)georgi-clan.de> Date: Mon Oct 8 09:33:38 2012 +0200 pirq_route_irqs is private Change-Id: I120913dac3150a72c2e66c74872ee00074ee0267 Signed-off-by: Patrick Georgi <patrick(a)georgi-clan.de> Reviewed-on: http://review.coreboot.org/1936 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> See http://review.coreboot.org/1936 for details. -gerrit

1 0

Patch set updated for coreboot: 23547dd Minor changes to .h files for samsung ARM part
by gerrit＠coreboot.org 28 Nov '12

28 Nov '12

just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1939 -gerrit commit 23547ddb94476a2f65cf76c11b019ca86419cc35 Author: Ronald G. Minnich <rminnich(a)gmail.com> Date: Wed Nov 28 10:03:59 2012 -0800 Minor changes to .h files for samsung ARM part With these changes we have a mostly compiling target. I'm still removing and pruning .h files, but hopefully later today I'll do the last few .h commits and move on to .c Change-Id: Ia82d787496184e028f37d7b67336d61fda75aa94 Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Reviewed-on: http://review.coreboot.org/1937 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/cpu/samsung/exynos5-common/spl.h | 2 +- src/cpu/samsung/exynos5250/clk.h | 2 +- src/cpu/samsung/exynos5250/cpu.h | 2 +- src/cpu/samsung/exynos5250/gpio.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cpu/samsung/exynos5-common/spl.h b/src/cpu/samsung/exynos5-common/spl.h index 1df4aed..afa9a8e 100644 --- a/src/cpu/samsung/exynos5-common/spl.h +++ b/src/cpu/samsung/exynos5-common/spl.h @@ -23,7 +23,7 @@ #ifndef __ASM_ARCH_EXYNOS_SPL_H__ #define __ASM_ARCH_EXYNOS_SPL_H__ -#include <cpu/samsung/exynos-common/cpu.h> +#include <cpu/samsung/exynos5-common/cpu.h> /* FIXME(dhendrix): non-common header included by a common header... */ #include <cpu/samsung/exynos5250/dmc.h> diff --git a/src/cpu/samsung/exynos5250/clk.h b/src/cpu/samsung/exynos5250/clk.h index 91b54fd..2de949a 100644 --- a/src/cpu/samsung/exynos5250/clk.h +++ b/src/cpu/samsung/exynos5250/clk.h @@ -22,7 +22,7 @@ #ifndef __EXYNOS5_CLK_H__ #define __EXYNOS5_CLK_H__ -#include <cpu/samsung/exynos-common/clk.h> +#include <cpu/samsung/exynos5-common/clk.h> #include <cpu/samsung/exynos5250/pinmux.h> /* diff --git a/src/cpu/samsung/exynos5250/cpu.h b/src/cpu/samsung/exynos5250/cpu.h index f6d7c65..afd985a 100644 --- a/src/cpu/samsung/exynos5250/cpu.h +++ b/src/cpu/samsung/exynos5250/cpu.h @@ -22,7 +22,7 @@ #ifndef _EXYNOS5250_CPU_H #define _EXYNOS5250_CPU_H -#include <cpu/samsung/exynos-common/cpu.h> +#include <cpu/samsung/exynos5-common/cpu.h> /* EXYNOS5 */ #define EXYNOS5_GPIO_PART6_BASE 0x03860000 /* Z<6:0> */ diff --git a/src/cpu/samsung/exynos5250/gpio.h b/src/cpu/samsung/exynos5250/gpio.h index b45cf5c..7606262 100644 --- a/src/cpu/samsung/exynos5250/gpio.h +++ b/src/cpu/samsung/exynos5250/gpio.h @@ -21,7 +21,7 @@ #ifndef EXYNOS5250_GPIO_H_ #define EXYNOS5250_GPIO_H_ -#include <cpu/samsung/exynos-common/gpio.h> +#include <cpu/samsung/exynos5-common/gpio.h> struct exynos5_gpio_part1 { struct s5p_gpio_bank a0;

1 0

Patch set updated for coreboot: 23547dd Minor changes to .h files for samsung ARM part
by gerrit＠coreboot.org 28 Nov '12

28 Nov '12

just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1940 -gerrit commit 23547ddb94476a2f65cf76c11b019ca86419cc35 Author: Ronald G. Minnich <rminnich(a)gmail.com> Date: Wed Nov 28 10:03:59 2012 -0800 Minor changes to .h files for samsung ARM part With these changes we have a mostly compiling target. I'm still removing and pruning .h files, but hopefully later today I'll do the last few .h commits and move on to .c Change-Id: Ia82d787496184e028f37d7b67336d61fda75aa94 Signed-off-by: Ronald G. Minnich <rminnich(a)gmail.com> Reviewed-on: http://review.coreboot.org/1937 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> --- src/cpu/samsung/exynos5-common/spl.h | 2 +- src/cpu/samsung/exynos5250/clk.h | 2 +- src/cpu/samsung/exynos5250/cpu.h | 2 +- src/cpu/samsung/exynos5250/gpio.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/cpu/samsung/exynos5-common/spl.h b/src/cpu/samsung/exynos5-common/spl.h index 1df4aed..afa9a8e 100644 --- a/src/cpu/samsung/exynos5-common/spl.h +++ b/src/cpu/samsung/exynos5-common/spl.h @@ -23,7 +23,7 @@ #ifndef __ASM_ARCH_EXYNOS_SPL_H__ #define __ASM_ARCH_EXYNOS_SPL_H__ -#include <cpu/samsung/exynos-common/cpu.h> +#include <cpu/samsung/exynos5-common/cpu.h> /* FIXME(dhendrix): non-common header included by a common header... */ #include <cpu/samsung/exynos5250/dmc.h> diff --git a/src/cpu/samsung/exynos5250/clk.h b/src/cpu/samsung/exynos5250/clk.h index 91b54fd..2de949a 100644 --- a/src/cpu/samsung/exynos5250/clk.h +++ b/src/cpu/samsung/exynos5250/clk.h @@ -22,7 +22,7 @@ #ifndef __EXYNOS5_CLK_H__ #define __EXYNOS5_CLK_H__ -#include <cpu/samsung/exynos-common/clk.h> +#include <cpu/samsung/exynos5-common/clk.h> #include <cpu/samsung/exynos5250/pinmux.h> /* diff --git a/src/cpu/samsung/exynos5250/cpu.h b/src/cpu/samsung/exynos5250/cpu.h index f6d7c65..afd985a 100644 --- a/src/cpu/samsung/exynos5250/cpu.h +++ b/src/cpu/samsung/exynos5250/cpu.h @@ -22,7 +22,7 @@ #ifndef _EXYNOS5250_CPU_H #define _EXYNOS5250_CPU_H -#include <cpu/samsung/exynos-common/cpu.h> +#include <cpu/samsung/exynos5-common/cpu.h> /* EXYNOS5 */ #define EXYNOS5_GPIO_PART6_BASE 0x03860000 /* Z<6:0> */ diff --git a/src/cpu/samsung/exynos5250/gpio.h b/src/cpu/samsung/exynos5250/gpio.h index b45cf5c..7606262 100644 --- a/src/cpu/samsung/exynos5250/gpio.h +++ b/src/cpu/samsung/exynos5250/gpio.h @@ -21,7 +21,7 @@ #ifndef EXYNOS5250_GPIO_H_ #define EXYNOS5250_GPIO_H_ -#include <cpu/samsung/exynos-common/gpio.h> +#include <cpu/samsung/exynos5-common/gpio.h> struct exynos5_gpio_part1 { struct s5p_gpio_bank a0;

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
90
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot November 2012