coreboot March 2011

coreboot@coreboot.org

71 participants
210 discussions

#175: Gift Baskets
by coreboot 01 Mar '11

01 Mar '11

#175: Gift Baskets ------------------------------------+---------------------------------- Reporter: ronnie.liloonline@… | Owner: stepan@… Type: defect | Status: new Priority: major | Milestone: Component: coreboot | Keywords: gift baskets Dependencies: | Patch Status: there is no patch ------------------------------------+---------------------------------- == Gift Baskets - How To Make Your Own Valentine's Day Gift Baskets == [[Image(http://s6.thisnext.com/media/largest_dimension/B3679D57.jpg)]] When you wanted to make such '''[http://www.giftbasketsplus.com/ gift baskets]''' in making things that can be better for them having such ways to have its ways that will make those people whom you wanted to give such '''baskets''' in a certain period of time. There are things that will make those people have such '''shopping baskets''' makings such ways to satisfy their needs in life living in this world. For such situations that a certain individual can have the things that will be best for them to think about such ways to have its best ways in life living. [[Image(http://www.withourbest.com/wp-content/uploads/2010/11/Corporate- Gift-Basket.png)]] Making things that is best for those people having the things that can be better for them having such '''[http://trac.cps-cms.org/ticket/2343 gift baskets]''' in a certain period of time. For the things that can be better for them in making such ways to have such ways that will make them have a '''gift basket''' that will make them have the things they may need in life. -- Ticket URL: <https://tracker.coreboot.org/trac/coreboot/ticket/175> coreboot <http://www.coreboot.org/>

1 0

(no subject)
by Sven Schnelle 01 Mar '11

01 Mar '11

Hi List, this patches are adding a new subsystemid option to sconfig. This option can be used to specify subsystem IDs in devicetree.cb, and is intended to replace the old Kconfig option. Main motivation for this patch is the fact that the current Kconfig mechanism only allows to set a Subsystem Vendor/Device ID per Board, but not per Device. My ThinkPad X60 and my T60 are using several subsystem device ids per Board, so we want to have something more flexible. A simple demo config which would equal the old Kconfig option: device pci_domain 0 on subsystemid 0xdead 0xbeef inherit device pci 00.0 on end device pci 01.0 on end device pci 02.0 on end end This tells sconfig that it should use 0xdead as Vendor and 0xbeef as device id for all devices below pci_domain 0. A more complex config (taken from X60): device pci_domain 0 on device pci 00.0 on # Host bridge subsystemid 0x17aa 0x2017 end device pci 02.0 on # VGA controller subsystemid 0x17aa 0x201a end device pci 02.1 on # display controller subsystemid 0x17aa 0x201a [...] device pci 1b.0 on # Audio Cnotroller subsystemid 0x17aa 0x2010 end device pci 1c.0 on end # Ethernet device pci 1c.1 on end # Atheros WLAN device pci 1d.0 on # USB UHCI subsystemid 0x17aa 0x200a end [...] This config would set different device IDs depending on the device.

1 2

[PATCH] First step in converting W83977TF early serial from included to linked
by Keith Hui 01 Mar '11

01 Mar '11

And here is the patch. abuild-tested. I will boot test it with P2B-LS and P3B-F tomorrow but I want this patch out there to generate some discussions and get more boot test coverage. This I believe falls under "infrastructure projects" [1]. This patch facilitates, for boards using Winbond W83977TF superio, dropping early_serial.c from #includes of their romstage, instead linking to them; and converts 12 of 13 mainboards using this superio to do exactly this. The lone board out, iei/nova4899r, is a Geode/CS5530 board that has not yet been converted to CAR or tiny bootblock. The rest are all slot 1/440BX/i82371eb boards that have been converted. At this stage I should leave converting CS5530 to tiny bootblock to someone better versed in this platform. The pnp_... functions defined in romcc_io.h now have a new home in arch/x86/lib/pnp.c, and is compiled and linked like any other C files meant for romstage. This patch puts the W83977TF early serial code in a state where it can be incorporated both through the old setup (ie. #included in mainboard romstage), or be compiled separately and linked into romstage. Once this conversion is done on all superios and all southbridges/boards have been converted, the few #ifdefs that made this possible can be cleaned out. Signed-off-by: Keith Hui <buurin(a)gmail.com> [1] http://www.coreboot.org/Infrastructure_Projects#Remove_.c_includes On Mon, Feb 28, 2011 at 1:00 PM, Keith Hui <buurin(a)gmail.com> wrote: > Hi all, > > In my pipeline is something more infrastructural, something different > from what I usually do - > > I am converting early serial code for Winbond W83977TF from code > included in romstage to compiled unit to be linked into romstage. > > 13 boards use this superio, some apparently still not converted to CAR > (including one Intel server board). I have yet to complete running > abuild on my change. Should I let it break when I submit it for review > given earlier buzz suggesting we leave non-CAR boards behind? > > The reason I'm doing this is I want to do this for ITE IT8705F, which > happens to have no board using it at the moment, but I want to test > this approach on a board that I can boot test right now. Enter the > P2B-LS and W83977TF. If this proof of concept works, we can start this > conversion one superio at a time and nail down one more goal of the > infrastructure refactoring. > > Thoughts and comments? > Thanks Keith

3 2

[commit] r6419 - trunk
by repository service 01 Mar '11

01 Mar '11

Author: oxygene Date: Tue Mar 1 09:09:22 2011 New Revision: 6419 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6419 Log: Fix double inclusion of toplevel Makefile.inc Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Patrick Georgi <patrick.georgi(a)secunet.com> Modified: trunk/Makefile Modified: trunk/Makefile ============================================================================== --- trunk/Makefile Tue Mar 1 08:30:14 2011 (r6418) +++ trunk/Makefile Tue Mar 1 09:09:22 2011 (r6419) @@ -44,6 +44,9 @@ export KCONFIG_AUTOHEADER := $(obj)/config.h export KCONFIG_AUTOCONFIG := $(obj)/auto.conf +# directory containing the toplevel Makefile.inc +TOPLEVEL := . + CONFIG_SHELL := sh KBUILD_DEFCONFIG := configs/defconfig UNAME_RELEASE := $(shell uname -r) @@ -73,9 +76,8 @@ all: real-all -# This include must come _before_ he pattern rules below! +# This include must come _before_ the pattern rules below! # Order _does_ matter for pattern rules. -include Makefile.inc include util/kconfig/Makefile # Three cases where we don't need fully populated $(obj) lists: @@ -93,6 +95,7 @@ endif ifeq ($(NOCOMPILE),1) +include $(TOPLEVEL)/Makefile.inc real-all: config else @@ -189,7 +192,7 @@ $(if $(subdirs),$(eval $(call evaluate_subdirs))) # collect all object files eligible for building -subdirs:=. +subdirs:=$(TOPLEVEL) $(eval $(call evaluate_subdirs)) src-to-obj=$(addsuffix .$(1).o, $(basename $(patsubst src/%, $(obj)/%, $($(1)-srcs))))

1 0

[commit] r6418 - trunk/src/northbridge/amd/lx
by repository service 28 Feb '11

28 Feb '11

Author: oxygene Date: Tue Mar 1 08:30:14 2011 New Revision: 6418 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6418 Log: Mark non-returning function as noreturn to help some compiler versions Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Patrick Georgi <patrick.georgi(a)secunet.com> Modified: trunk/src/northbridge/amd/lx/raminit.c Modified: trunk/src/northbridge/amd/lx/raminit.c ============================================================================== --- trunk/src/northbridge/amd/lx/raminit.c Tue Mar 1 08:26:00 2011 (r6417) +++ trunk/src/northbridge/amd/lx/raminit.c Tue Mar 1 08:30:14 2011 (r6418) @@ -32,7 +32,7 @@ printk(BIOS_DEBUG, " * %s\n", s); } -static void hcf(void) +static void __attribute__((noreturn)) hcf(void) { print_emerg("DIE\n"); /* this guarantees we flush the UART fifos (if any) and also

1 0

[commit] r6417 - in trunk/payloads/libpayload/include: . pci
by repository service 28 Feb '11

28 Feb '11

Author: oxygene Date: Tue Mar 1 08:26:00 2011 New Revision: 6417 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6417 Log: libpayload: Add more libpci-compatibility (#defines) Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Modified: trunk/payloads/libpayload/include/pci.h trunk/payloads/libpayload/include/pci/pci.h Modified: trunk/payloads/libpayload/include/pci.h ============================================================================== --- trunk/payloads/libpayload/include/pci.h Tue Mar 1 08:24:53 2011 (r6416) +++ trunk/payloads/libpayload/include/pci.h Tue Mar 1 08:26:00 2011 (r6417) @@ -42,6 +42,8 @@ #define REG_SUBSYS_VENDOR_ID 0x2C #define REG_SUBSYS_ID 0x2E +#define REG_COMMAND_IO (1 << 0) +#define REG_COMMAND_MEM (1 << 1) #define REG_COMMAND_BM (1 << 2) #define HEADER_TYPE_NORMAL 0 Modified: trunk/payloads/libpayload/include/pci/pci.h ============================================================================== --- trunk/payloads/libpayload/include/pci/pci.h Tue Mar 1 08:24:53 2011 (r6416) +++ trunk/payloads/libpayload/include/pci/pci.h Tue Mar 1 08:26:00 2011 (r6417) @@ -39,6 +39,32 @@ #define PCI_SUBSYSTEM_VENDOR_ID REG_SUBSYS_VENDOR_ID #define PCI_SUBSYSTEM_ID REG_SUBSYS_ID +#define PCI_COMMAND REG_COMMAND +#define PCI_COMMAND_IO REG_COMMAND_IO +#define PCI_COMMAND_MEMORY REG_COMMAND_MEM +#define PCI_COMMAND_MASTER REG_COMMAND_BM + +#define PCI_HEADER_TYPE REG_HEADER_TYPE +#define PCI_HEADER_TYPE_NORMAL HEADER_TYPE_NORMAL +#define PCI_HEADER_TYPE_BRIDGE HEADER_TYPE_BRIDGE +#define PCI_HEADER_TYPE_CARDBUS HEADER_TYPE_CARDBUS + +#define PCI_BASE_ADDRESS_0 0x10 +#define PCI_BASE_ADDRESS_1 0x14 +#define PCI_BASE_ADDRESS_2 0x18 +#define PCI_BASE_ADDRESS_3 0x1c +#define PCI_BASE_ADDRESS_4 0x20 +#define PCI_BASE_ADDRESS_5 0x24 +#define PCI_BASE_ADDRESS_SPACE 1 // mask +#define PCI_BASE_ADDRESS_SPACE_IO 1 +#define PCI_BASE_ADDRESS_SPACE_MEM 0 +#define PCI_BASE_ADDRESS_IO_MASK ~0xf +#define PCI_BASE_ADDRESS_MEM_MASK ~0x3 + +#define PCI_ROM_ADDRESS 0x30 +#define PCI_ROM_ADDRESS1 0x38 // on bridges +#define PCI_ROM_ADDRESS_MASK ~0x7ff + struct pci_dev { u16 domain; u8 bus, dev, func;

1 0

[commit] r6416 - in trunk/payloads/libpayload: include/pci libpci
by repository service 28 Feb '11

28 Feb '11

Author: oxygene Date: Tue Mar 1 08:24:53 2011 New Revision: 6416 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6416 Log: libpayload: Implement pci_cleanup() Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Modified: trunk/payloads/libpayload/include/pci/pci.h trunk/payloads/libpayload/libpci/libpci.c Modified: trunk/payloads/libpayload/include/pci/pci.h ============================================================================== --- trunk/payloads/libpayload/include/pci/pci.h Tue Mar 1 08:23:49 2011 (r6415) +++ trunk/payloads/libpayload/include/pci/pci.h Tue Mar 1 08:24:53 2011 (r6416) @@ -70,6 +70,7 @@ struct pci_access *pci_alloc(void); void pci_init(struct pci_access*); +void pci_cleanup(struct pci_access*); char *pci_filter_parse_slot(struct pci_filter*, const char*); int pci_filter_match(struct pci_filter*, struct pci_dev*); void pci_filter_init(struct pci_access*, struct pci_filter*); Modified: trunk/payloads/libpayload/libpci/libpci.c ============================================================================== --- trunk/payloads/libpayload/libpci/libpci.c Tue Mar 1 08:23:49 2011 (r6415) +++ trunk/payloads/libpayload/libpci/libpci.c Tue Mar 1 08:24:53 2011 (r6416) @@ -77,11 +77,15 @@ return pacc; } -void pci_init(struct pci_access* pacc) +void pci_init(struct pci_access *pacc) { memset(pacc, 0, sizeof(*pacc)); } +void pci_cleanup(__attribute__ ((unused)) struct pci_access *pacc) +{ +} + void pci_filter_init(struct pci_access* pacc, struct pci_filter* pf) { pf->domain = -1;

1 0

[commit] r6415 - in trunk/payloads/libpayload: include libc
by repository service 28 Feb '11

28 Feb '11

Author: oxygene Date: Tue Mar 1 08:23:49 2011 New Revision: 6415 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6415 Log: libpayload: Implement ffs() Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Added: trunk/payloads/libpayload/include/strings.h trunk/payloads/libpayload/libc/strings.c Modified: trunk/payloads/libpayload/libc/Makefile.inc Added: trunk/payloads/libpayload/include/strings.h ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/payloads/libpayload/include/strings.h Tue Mar 1 08:23:49 2011 (r6415) @@ -0,0 +1,35 @@ +/* + * This file is part of the libpayload project. + * + * Copyright (C) 2011 secunet Security Networks AG + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. The name of the author may not be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#ifndef _STRINGS_H +#define _STRINGS_H + +int ffs(int i); + +#endif Modified: trunk/payloads/libpayload/libc/Makefile.inc ============================================================================== --- trunk/payloads/libpayload/libc/Makefile.inc Tue Mar 1 08:13:10 2011 (r6414) +++ trunk/payloads/libpayload/libc/Makefile.inc Tue Mar 1 08:23:49 2011 (r6415) @@ -32,7 +32,7 @@ TARGETS-$(CONFIG_LIBC) += libc/memory.o libc/ctype.o libc/ipchecksum.o libc/lib.o TARGETS-$(CONFIG_LIBC) += libc/rand.o libc/time.o libc/exec.o TARGETS-$(CONFIG_LIBC) += libc/readline.o libc/getopt_long.o libc/sysinfo.o -TARGETS-$(CONFIG_LIBC) += libc/args.o +TARGETS-$(CONFIG_LIBC) += libc/args.o libc/strings.o # should be moved to coreboot directory TARGETS-$(CONFIG_LAR) += libc/lar.o Added: trunk/payloads/libpayload/libc/strings.c ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ trunk/payloads/libpayload/libc/strings.c Tue Mar 1 08:23:49 2011 (r6415) @@ -0,0 +1,40 @@ +/* + * This file is part of the libpayload project. + * + * Copyright (C) 2011 secunet Security Networks AG + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * 1. Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. The name of the author may not be used to endorse or promote products + * derived from this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +int ffs(int i) +{ + int count = 1; + if (i == 0) return 0; + + while ((i & 1) != 1) { + i>>=1; + count++; + } + return count; +}

1 0

[commit] r6414 - trunk/payloads/libpayload/include
by repository service 28 Feb '11

28 Feb '11

Author: oxygene Date: Tue Mar 1 08:13:10 2011 New Revision: 6414 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6414 Log: Some more standard types and defines (libpayload) Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Modified: trunk/payloads/libpayload/include/limits.h trunk/payloads/libpayload/include/stdint.h Modified: trunk/payloads/libpayload/include/limits.h ============================================================================== --- trunk/payloads/libpayload/include/limits.h Tue Mar 1 08:12:08 2011 (r6413) +++ trunk/payloads/libpayload/include/limits.h Tue Mar 1 08:13:10 2011 (r6414) @@ -40,4 +40,6 @@ # endif #endif +#define UINT_MAX (unsigned int)0xffffffff + #endif Modified: trunk/payloads/libpayload/include/stdint.h ============================================================================== --- trunk/payloads/libpayload/include/stdint.h Tue Mar 1 08:12:08 2011 (r6413) +++ trunk/payloads/libpayload/include/stdint.h Tue Mar 1 08:13:10 2011 (r6414) @@ -27,4 +27,9 @@ * SUCH DAMAGE. */ +#ifndef __STDINT_H +#define __STDINT_H #include <arch/types.h> + +typedef unsigned long uintptr_t; +#endif

1 0

[commit] r6413 - trunk/payloads/libpayload/bin
by repository service 28 Feb '11

28 Feb '11

Author: oxygene Date: Tue Mar 1 08:12:08 2011 New Revision: 6413 URL: https://tracker.coreboot.org/trac/coreboot/changeset/6413 Log: Add lib/ to the default library path of lpgcc, so -l works Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com> Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Modified: trunk/payloads/libpayload/bin/lpgcc Modified: trunk/payloads/libpayload/bin/lpgcc ============================================================================== --- trunk/payloads/libpayload/bin/lpgcc Mon Feb 28 19:09:58 2011 (r6412) +++ trunk/payloads/libpayload/bin/lpgcc Tue Mar 1 08:12:08 2011 (r6413) @@ -123,7 +123,7 @@ _CFLAGS="$_CFLAGS -I`$DEFAULT_CC -m32 -print-search-dirs | head -n 1 | cut -d' ' -f2`include" -_LDFLAGS="$_LDSCRIPT -static" +_LDFLAGS="-L$BASE/../lib $_LDSCRIPT -static" if [ $DOLINK -eq 0 ]; then if [ $DEBUGME -eq 1 ]; then @@ -134,7 +134,7 @@ else _LIBGCC=`$DEFAULT_CC -m32 -print-libgcc-file-name` if [ $DEBUGME -eq 1 ]; then - echo "$DEFAULT_CC $_CFLAGS $_LDFLAGS $_ARCHLIBDIR/head.o $CMDLINE $_LIBDIR/libpayload.a $_LIBGCC" + echo "$DEFAULT_CC $_CFLAGS $_LDFLAGS $_ARCHLIBDIR/head.o $CMDLINE -lpayload $_LIBGCC" fi # Note: $_ARCHLIBDIR/head.o must be the first object being linked, because it @@ -142,5 +142,5 @@ # header to be placed below 0x2000 in the resulting image. See: # http://www.gnu.org/software/grub/manual/multiboot/html_node/OS-image-format… - $DEFAULT_CC $_CFLAGS $_LDFLAGS $_ARCHLIBDIR/head.o $CMDLINE $_LIBDIR/libpayload.a $_LIBGCC + $DEFAULT_CC $_CFLAGS $_LDFLAGS $_ARCHLIBDIR/head.o $CMDLINE -lpayload $_LIBGCC fi

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

coreboot March 2011