On Thu, Mar 17, 2011 at 3:21 PM, Vibrans, Frank <Frank.Vibrans(a)amd.com> wrote:
> This patch performs some cleanup and file shrinkage of the AMD Agesa code.
>
>
>
> Signed-off-by Frank Vibrans <frank.vibrans(a)amd.com>
>
Acked-by: Marc Jones <marcj303(a)gmail.com>
r6452
--
http://se-eng.com
Hi,
attached patches rework the device string parser in FILO so it should be
easier to understand, and adds some more ways to specify
devices/partitions. Specifically:
2-refactor-dev-parsing.diff:
- copy_path_to_filo_bootline() erases the target location instead
of expecting the callers to do so
- callers of copy_path_to_filo_bootline() don't erase the target
variables themselves.
This fixes an issue where the function is called without the variable
being erased. I couldn't think of any plausible scenario in which the
old behaviour is desirable.
3-rewrite-drive-specification-parser.diff:
- copy_path_to_filo_bootline is rewritten for clarity.
- copy_path_to_filo_bootline now supports @address syntax in grub-style
device names.
- use strtoul instead of a custom number parser (theoretically allows
for >99 disks/partitions, but I guess we'll never have to work with
that)
The old implementation of the function was a mess of hidden state
dragged around in incidental configuration in variables. The current
code flow should be easier to follow.
4-handle-partition-only-changes.diff:
- Allow new syntax "(,N)" (grub-style) or "N:" (filo/linux-style) which
simply switches to a different partition on the current device.
Use case: one partition with filo.lst, another with kernels, filo.lst
references the kernel as "5:/boot/kernel" and it works no matter the
drive name.
Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com>
--
Patrick Georgi
SINA-Development - High Security
secunet Security Networks AG - Mergenthalerallee 77 - 65760 Eschborn, Germany
Phone +49 201 54 54-3610 - Fax +49 201 54 54-1325 - www.secunet.com
Sitz: Kronprinzenstraße 30, 45128 Essen / Amtsgericht Essen HRB 13615
Vorstand: Dr. Rainer Baumgart (Vors.), Thomas Koelzer, Thomas Pleines
Aufsichtsratsvorsitzender: Dr. Karsten Ottenberg
Author: oxygene
Date: Thu Mar 17 13:34:15 2011
New Revision: 6451
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6451
Log:
Fix power_on_after_fail handling on AMD SB600
Bit 0 of pm reg#74 have to be set turn on system after power resumes.
See '42661_sb600_rrg_nda_3.02.pdf' (or '46155_sb600_rrg_pub_3.03.pdf')
for details, look for 'PwrFailShadow'.
[Patrick: I didn't include the get_options reorganization as get_option
doesn't overwrite "on" if power_on_after_fail isn't found in CMOS.
Style changes were also left out.]
Signed-off-by: Josef Kellermann <seppk(a)arcor.de>
Acked-by: Patrick Georgi <patrick.georgi(a)secunet.com>
Modified:
trunk/src/southbridge/amd/sb600/sm.c
Modified: trunk/src/southbridge/amd/sb600/sm.c
==============================================================================
--- trunk/src/southbridge/amd/sb600/sm.c Thu Mar 17 13:20:04 2011 (r6450)
+++ trunk/src/southbridge/amd/sb600/sm.c Thu Mar 17 13:34:15 2011 (r6451)
@@ -94,7 +94,7 @@
byte = pm_ioread(0x74);
byte &= ~0x03;
if (on) {
- byte |= 2;
+ byte |= 1 << 0;
}
byte |= 1 << 2;
pm_iowrite(0x74, byte);
Author: oxygene
Date: Thu Mar 17 08:47:49 2011
New Revision: 6449
URL: https://tracker.coreboot.org/trac/coreboot/changeset/6449
Log:
More complete control over KERNELVERSION variable
Allow using revision information (from svn or git) even if the version
number is changed on the command line (eg. make KERNELVERSION='11.03$(REV)')
or dropping it entirely if having that information in the coreboot binary is
not desired.
Signed-off-by: Patrick Georgi <patrick.georgi(a)secunet.com>
Acked-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Modified:
trunk/Makefile.inc
Modified: trunk/Makefile.inc
==============================================================================
--- trunk/Makefile.inc Tue Mar 15 10:52:17 2011 (r6448)
+++ trunk/Makefile.inc Thu Mar 17 08:47:49 2011 (r6449)
@@ -19,7 +19,8 @@
#######################################################################
# misleadingly named, this is the coreboot version
-export KERNELVERSION := 4.0
+REV=-r$(shell if [ -d $(top)/.svn -a -f "`which svnversion`" ]; then svnversion $(top); else if [ -d $(top)/.git -a -f "`which git`" ]; then git --git-dir=/$(top)/.git log|grep git-svn-id|cut -f 2 -d@|cut -f 1 -d' '|sort -g|tail -1; fi; fi)
+export KERNELVERSION := 4.0$(REV)
#######################################################################
# Basic component discovery
@@ -123,7 +124,7 @@
printf "/* build system definitions (autogenerated) */\n" > $(obj)/build.ht
printf "#ifndef __BUILD_H\n" >> $(obj)/build.ht
printf "#define __BUILD_H\n\n" >> $(obj)/build.ht
- printf "#define COREBOOT_VERSION \"$(KERNELVERSION)-r$(shell if [ -d $(top)/.svn -a -f "`which svnversion`" ]; then svnversion $(top); else if [ -d $(top)/.git -a -f "`which git`" ]; then git --git-dir=/$(top)/.git log|grep git-svn-id|cut -f 2 -d@|cut -f 1 -d' '|sort -g|tail -1; fi; fi)\"\n" >> $(obj)/build.ht
+ printf "#define COREBOOT_VERSION \"$(KERNELVERSION)\"\n" >> $(obj)/build.ht
printf "#define COREBOOT_EXTRA_VERSION \"$(COREBOOT_EXTRA_VERSION)\"\n" >> $(obj)/build.ht
printf "#define COREBOOT_BUILD \"`LANG= date`\"\n" >> $(obj)/build.ht
printf "\n" >> $(obj)/build.ht
Hello All,
I have a rom image witch contains an JCALG1 archive.
I would like to know what it contains , does anyone know of a ready to use
tool that can extract an JCALG1 archive?
Thanks, Nils.
I have \_S4 in my dsdt.asl. But the dmesg only reports:
ACPI: (supports S0 S1 S2 S3 S5)
And cat /sys/power/state only says:
Standby mem
So what else is needed?
Thanks.
Zheng
Hi,
I'm making FreeBSD port of nvramtool and I don't want to download full
coreboot snapshot to build only nvramtool. Where can I find snapshots of
nvramtool only? If you don't separate that things, don't you mind if I
will make snapshots by myself and put it on my website (and freebsd.org
maybe)?
Thanks.
--
Andrey Zonov
Hi,
attached patch improves flexibility on coreboot version strings in the
final binary. See attachment for details.
--
Patrick Georgi
SINA-Development - High Security
secunet Security Networks AG - Mergenthalerallee 77 - 65760 Eschborn, Germany
Phone +49 201 54 54-3610 - Fax +49 201 54 54-1325 - www.secunet.com
Sitz: Kronprinzenstraße 30, 45128 Essen / Amtsgericht Essen HRB 13615
Vorstand: Dr. Rainer Baumgart (Vors.), Thomas Koelzer, Thomas Pleines
Aufsichtsratsvorsitzender: Dr. Karsten Ottenberg