Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/438
-gerrit
commit f6be7926e0d91a280ea097e510913eacc3606d20
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Mon Nov 21 08:15:39 2011 +0200
Eliminate bad menuconfig combinations
Offer only CBFS_PREFIX "fallback" or "normal", as those names
are hard-coded in the bootblock.
Only with the choice "fallback" user is provided with the option to
select bootblock behaviour.
With choice "normal" build runs in image update mode and user has to
provide a template (with bootblock and fallback) as build/coreboot.rom.
Change-Id: Ie89c2f89245beec70ebb14326437d71699c367b8
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
src/Kconfig | 20 +++++++++++++++-----
src/arch/x86/Kconfig | 9 ++-------
2 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/src/Kconfig b/src/Kconfig
index 525d452..fcea4f3 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -39,12 +39,22 @@ config LOCALVERSION
the coreboot version number, so that you can easily distinguish
boot logs of different boards from each other.
+choice
+ prompt "CBFS prefix to use"
+ default CBFS_PREFIX_FALLBACK
+
+config CBFS_PREFIX_FALLBACK
+ bool "fallback"
+
+config CBFS_PREFIX_NORMAL
+ bool "normal"
+
+endchoice
+
config CBFS_PREFIX
- string "CBFS prefix to use"
- default "fallback"
- help
- Select the prefix to all files put into the image. It's "fallback"
- by default, "normal" is a common alternative.
+ string
+ default "fallback" if CBFS_PREFIX_FALLBACK
+ default "normal" if CBFS_PREFIX_NORMAL
choice
prompt "Compiler"
diff --git a/src/arch/x86/Kconfig b/src/arch/x86/Kconfig
index e71d0f3..d8e584c 100644
--- a/src/arch/x86/Kconfig
+++ b/src/arch/x86/Kconfig
@@ -36,6 +36,7 @@ config MAX_REBOOT_CNT
choice
prompt "Bootblock behaviour"
default X86_BOOTBLOCK_SIMPLE
+ depends on !UPDATE_IMAGE
config X86_BOOTBLOCK_SIMPLE
bool "Always load fallback"
@@ -51,13 +52,7 @@ config BOOTBLOCK_SOURCE
default "bootblock_normal.c" if X86_BOOTBLOCK_NORMAL
config UPDATE_IMAGE
- bool "Update existing coreboot.rom image"
- default n
- help
- If this option is enabled, no new coreboot.rom file
- is created. Instead it is expected that there already
- is a suitable file for further processing.
- The bootblock will not be modified.
+ def_bool !CBFS_PREFIX_FALLBACK
config ROMCC
bool
Kyösti Mälkki (kyosti.malkki(a)gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/435
-gerrit
commit 887edeb201b646ca51fd92a866b4cac087c99a4c
Author: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Date: Mon Nov 21 19:12:50 2011 +0200
Via Epia-N and C3: Set ioapic delivery type in Kconfig
The original comment says it's a Via C3 and not Epia requirement
to deliver IOAPIC interrupts on APIC serial bus. If someone can
confirm this, set delivery type under cpu/via/model_c3 instead.
Change-Id: I73c55755e0ec1ac5756b4ee7ccdfc8eb93184e4f
Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
---
src/Kconfig | 5 +++++
src/arch/x86/lib/ioapic.c | 9 ---------
src/mainboard/via/epia-n/Kconfig | 5 +++++
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/src/Kconfig b/src/Kconfig
index 525d452..cbb95cb 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -239,6 +239,11 @@ config IOAPIC
bool
default n
+# Boards with CPU_VIA_C3 may need to override delivery type.
+config IOAPIC_DELIVERY_TYPE
+ int
+ default 1
+
# TODO: Can probably be removed once all chipsets have kconfig options for it.
config VIDEO_MB
int
diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c
index 91e43a6..fee2ca1 100644
--- a/src/arch/x86/lib/ioapic.c
+++ b/src/arch/x86/lib/ioapic.c
@@ -180,15 +180,6 @@ static void load_vectors(u32 ioapic_base, u8 bsp_lapicid)
}
}
-// XXX this decision should probably be made elsewhere, and
-// it's the C3, not the EPIA this depends on.
-
-#if CONFIG_EPIA_VT8237R_INIT
-#define CONFIG_IOAPIC_DELIVERY_TYPE 0
-#else
-#define CONFIG_IOAPIC_DELIVERY_TYPE 1
-#endif
-
/**
* Assign IOAPIC with an ID
*
diff --git a/src/mainboard/via/epia-n/Kconfig b/src/mainboard/via/epia-n/Kconfig
index 4806753..5a88f6a 100644
--- a/src/mainboard/via/epia-n/Kconfig
+++ b/src/mainboard/via/epia-n/Kconfig
@@ -28,4 +28,9 @@ config IRQ_SLOT_COUNT
int
default 7
+# IRQ delivery on APIC bus may be a Via C3 CPU requirement.
+config IOAPIC_DELIVERY_TYPE
+ int
+ default 0
+
endif # BOARD_VIA_EPIA_N